Removing deprecated fields and functions related to rego-v1 compatibility #6542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity to remove API ambiguity. Also deprecating `ParserOptions.EffectiveRegoVersion()`, which will be removed in a future release. Signed-off-by: Johan Fylling <johan.dev@fylling.se>
ashutosh-narkar
force-pushed
the
rego-v1/remove_deprecated
branch
from
48a315b
to
1ee3cbf
Compare
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ast/parser.go
Outdated
| // RegoV1Compatible takes precedence, and if set to true, RegoVersion is ignored. | ||
| // Deprecated: use RegoVersion instead. Will be removed in a future version of OPA. | ||
| RegoV1Compatible bool | ||
| // RegoV1Compatible additionally affects the Rego version. |
There was a problem hiding this comment.
We probably don't need this comment.
There was a problem hiding this comment.
Yes. Good catch 👍
ashutosh-narkar
previously approved these changes
Jan 24, 2024
Signed-off-by: Johan Fylling <johan.dev@fylling.se>
ashutosh-narkar
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to remove API ambiguity.
Also deprecating
ParserOptions.EffectiveRegoVersion(), which will be removed in a future release.