Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new function crypto.x509.parse_and_verify_certificates_with_options #6643

Merged

Conversation

yogisinha
Copy link
Contributor

Why the changes in this PR are needed?

parse and verify x509 certificates with additional options in package x509.crypto was requested

What are the changes in this PR?

a new builtin function was added. Following files are modified
ast/builtins.go
topdown/crypto.go
topdown/crypto_test.go
builtin_metadata.json
capabilities.json

Notes to assist PR review:

Further comments:

Copy link

netlify bot commented Mar 23, 2024

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit f0a8cb5
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/66042064629c5600081694a2
😎 Deploy Preview https://deploy-preview-6643--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…options. Fixes open-policy-agent#5882

Signed-off-by: Yogesh Sinha <sinhayogi@gmail.com>
@charlieegan3
Copy link
Contributor

Thanks for this @yogisinha, I have tested this now myself on my machine and think we're good to go now! 🚢

Have you got a use case for this built-in where you work? Do you think we have enough docs for Rego in this area?

@charlieegan3 charlieegan3 merged commit ea0dc02 into open-policy-agent:main Mar 27, 2024
26 checks passed
@yogisinha
Copy link
Contributor Author

yogisinha commented Mar 27, 2024

@charlieegan3 ,

Thanks for this @yogisinha, I have tested this now myself on my machine and think we're good to go now! 🚢

Have you got a use case for this built-in where you work? Do you think we have enough docs for Rego in this area?

No we don't have any use cases for this in our company. I think the Rego docs are good as we went through many iterations.

Just a general question. Whats the best way to maintain git hygiene when I am working on an issue.

  1. Do I need to do git pull upstream main (my upstream points to opa github) every now and then to keep my branch synced up with main branch. Because whenever I do rebase, I get merge conflicts. don't know why ?
  2. Any other suggestions on git hygiene.

@charlieegan3
Copy link
Contributor

Hey, good question. The best thing to do is to periodically run git fetch origin && git rebase origin/main and run this on your local machine, running git rebase --continue once you have addressed any issues. Then use git push -f $BRANCH to update the contents of the remote branch of your fork. This will remove the warnings on GH, and make it easier to get changes in.

tsidebottom pushed a commit to tsidebottom/opa- that referenced this pull request Apr 17, 2024
…options. Fixes open-policy-agent#5882 (open-policy-agent#6643)

Signed-off-by: Yogesh Sinha <sinhayogi@gmail.com>
Signed-off-by: Thomas Sidebottom <thomas.sidebottom@va.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants