Suppress not found error when applying remove operation #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundle/store.go
Outdated
| @@ -959,6 +959,9 @@ func applyPatches(ctx context.Context, store storage.Store, txn storage.Transact | |||
|
|
|||
| // apply the patch | |||
| if err := store.Write(ctx, txn, op, path, pat.Value); err != nil { | |||
| if op == storage.RemoveOp { | |||
| return suppressNotFound(err) | |||
There was a problem hiding this comment.
Oh yeah okk. I reverted the change and updated the doc then.
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: 0marq <45561584+0marq@users.noreply.github.com>
Update remove description to mention that target path must exist. Signed-off-by: 0marq <45561584+0marq@users.noreply.github.com>
Signed-off-by: 0marq <45561584+0marq@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
Running remove operation on data that is not present should not return an error.
What are the changes in this PR?
In function
applyPatchescallsuppressNotFoundfunction on the output ofstore.Writeif operation is removeNotes to assist PR review:
Further comments: