Fix OpenTelemetry graceful shutdown. #6738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
David-Wobrock
force-pushed
the
fix-opentelemetry-graceful-shutdown
branch
10 times, most recently
from
10a5921
to
a802c52
Compare
David-Wobrock
changed the title
ashutosh-narkar
force-pushed
the
fix-opentelemetry-graceful-shutdown
branch
from
a802c52
to
1092a10
Compare
There was a problem hiding this comment.
@David-Wobrock the change looks good. Just one comment on the test.
When running OPA with the distributed tracing option enabled, the OpenTelemetry trace exporter is not gracefully shut down when the server is stopped. This PR fixes that issues by moving the trace exporter shutdown in the gracefulServerShutdown function. Fixes: open-policy-agent#6651 Signed-off-by: Nicolas Chotard <nicolas.chotard@backmarket.com> Signed-off-by: David Wobrock <david.wobrock@backmarket.com>
David-Wobrock
force-pushed
the
fix-opentelemetry-graceful-shutdown
branch
from
1092a10
to
de44f77
Compare
|
Thanks for the review @ashutosh-narkar 🙏 I pushed the edits. Let me know if I can do further changes :) |
| }() | ||
| <-done | ||
|
|
||
| expected := "Failed to shutdown OpenTelemetry trace exporter gracefully." |
There was a problem hiding this comment.
Can we also have a test where the trace exporter does not shutdown gracefully?
There was a problem hiding this comment.
I guess the variable is misnamed, since we don't expected this message to be present in the logs - and thus test that the trace exporter did shutdown gracefully.
But anyway, I wouldn't know how to write a test where the trace exporter doesn't shutdown gracefully 😕
I'd need some help here :)
Or we could add such a test in a later PR, and start with this fix for now.
ashutosh-narkar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why the changes in this PR are needed?
When running OPA with the distributed tracing option enabled, the OpenTelemetry trace exporter is not gracefully shut down when the server is stopped.
What are the changes in this PR?
This PR fixes that issues by moving the trace exporter shutdown in the gracefulServerShutdown function.
Notes to assist PR review:
Picked up from #6664
Further comments:
Fixes #6651.
This bug seems to have been introduced by this commit.