Fix Issue #16 - Change openpomodoro client init #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --directory flag does not work, all commands use the default `~/.pomodoro` directory even when the flag is provided. With the current code, `directoryFlag` is always an empty string when passed to the openpomodoro.NewClient function because the flag has not been parsed yet at this time. Moving to the PersistentPreRun hook ensures that all commands will initialize the client with the correct flag value. Co-authored-by: hugobally <hugobally@users.noreply.github.com>
hugobally
commented
Nov 14, 2022
| var ( | ||
| client *openpomodoro.Client | ||
| settings *openpomodoro.Settings | ||
| settings = &openpomodoro.DefaultSettings |
There was a problem hiding this comment.
Since the settings var is not initalized during init() anymore, we need to load it with the default settings otherwise the start command will segfault by trying to access settings on init. (see start.go:31)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #16
The
--directoryflag does not work, all commands use the default~/.pomodorodirectory even when the flag is provided. With the current code,directoryFlagis always an empty string when passed to theopenpomodoro.NewClientfunction because the flag has not been parsed yet at this time.Moving to the
PersistentPreRunhook ensures that all commands will initialize the client with the correct flag value.Tested on ArchLinux but I don´t think the issue is platform dependent.
Co-authored-by: hugobally hugobally@users.noreply.github.com