Addtional work to clean up fedora rpmlint. #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved the License, Release and ChangeLog issues.
Copied the LICENSE file over COPYING to elliminate the symlink.
Updated Makefile.am and regenerated.
Forced a dependency on libc to elliminate the
shared-lib-without-dependency-information Error.
Updated src/Makefile.am and regenerated.
Include most of Antonio's <anto.trande@gmail.com> suggestions.
* COPYING: Copy LICENSE over COPYING, Remove symlink.
* Makefile.am (dist_license_DATA): Change to LICENSE.
(dist_doc_DATA): Restore COPYING to list.
* Makefile.in: Regenerate from automake.
* aclocal.m4: Regenerate from aclocal.
* configure: Regenerate from autoconf.
* src/Makefile.am: Add libpvec_la_LIBADD = -lc
* src/Makefile.in: Regenerate from automake.
* pveclib.spec (Release): 1.
(License): ASL 2.0.
(%description): s/intrinsics/intrinsic/.
(%prep): Use %autosetup.
(%build): Use %make_build.
(%install): Use %make_install.
Move %check after %make_install.
(%license): Change to LICENSE.
(%doc): Insert COPYING.
(%files devel): Simplify %{_includedir}/pveclib.
Signed-off-by: Steven Munroe <sjmunroe@homer53.localdomain>
|
The rpmlint spell checker does not think intrinsics is a word. :(
Actually most spell checkers don't. Intrinsic is ok, intrinsics is not.
I could change s/intrinsic/built-ins/
…On Wed, Jul 10, 2019 at 8:27 AM Paul Clarke ***@***.***> wrote:
***@***.**** approved this pull request.
one teeny nit
------------------------------
In pveclib.spec
<#79 (comment)>:
> %description
A library of useful vector operations for PowerISA 2.06 or later. Pveclib
-builds on the PPC vector intrinsics provided by <altivec.h> to provide higher
+builds on the PPC vector intrinsic provided by <altivec.h> to provide higher
I think we lost an s here.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#79?email_source=notifications&email_token=AIEI2IORTKB5QCHGRCTUQZDP6XPUTA5CNFSM4H7JZNY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6AKUMQ#pullrequestreview-260090418>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEI2ILHTCNFVFH5WQYFWTLP6XPUTANCNFSM4H7JZNYQ>
.
|
tuliom
approved these changes
Jul 10, 2019
|
***@***.***
weird that is the Fedora VM where I test.
Ok looks like I need to do some local git setup on that machine.
…On Wed, Jul 10, 2019 at 9:02 AM Tulio Magno Quites Machado Filho < ***@***.***> wrote:
***@***.**** approved this pull request.
The changes look good to me, but I suggest to review the author, committer
and signed-off-by email addresses used in this commit. They're pointing to
a broken email address.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#79?email_source=notifications&email_token=AIEI2IKHTLCEN25RYLNYK3LP6XTXPA5CNFSM4H7JZNY2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB6AQOZY#pullrequestreview-260114279>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIEI2IJRYA5EE4NH7Z57RSLP6XTXPANCNFSM4H7JZNYQ>
.
|
* pveclib.spec (%description): s/intrinsics/built-ins/. Signed-off-by: Steven Munroe <munroesj52@gmail.com>
inconstante
reviewed
Jul 11, 2019
inconstante
approved these changes
Jul 11, 2019
|
Paul it looks like I am using Paul Clarke pc@us.ibm.com in the MAINTAINERS.txt and configure.ac [AC_INIT]. I assume the correct email is now Paul Clarke pacman@us.ibm.com? |
Paul's reply: |
Separate libpvec.a from devel by creating static rpm. Other minor updates. * pveclib.spec: Move global description above package devel. Spelling channge s/intrinsics/built-ins/. (%package static): Add. (%files devel): Add %doc README.md. Remove libpvec.a. (%files static): Add. Signed-off-by: Steven Munroe <munroesj52@gmail.com>
…into fedora-one0two merge updates from devel laptop system
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved the License, Release and ChangeLog issues.
Copied the LICENSE file over COPYING to elliminate the symlink.
Updated Makefile.am and regenerated.
Forced a dependency on libc to elliminate the
shared-lib-without-dependency-information Error.
Updated src/Makefile.am and regenerated.
Include most of Antonio's anto.trande@gmail.com suggestions.
Signed-off-by: Steven Munroe munroesj52@gmail.com