Skip to content

Commit

Permalink
Improve error traces for MBOX errors
Browse files Browse the repository at this point in the history
If an error flag is found to be set when reading a mbox msg we want
to print out the error status register in addition to stating that
an error occured.

Change-Id: I56267880bf6d8ea3edc0bf1ff7bf25c1cf900361
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/67520
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Dean Sanner <dsanner@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Oct 16, 2018
1 parent 30de5c8 commit 0aed8ab
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/usr/mbox/mboxdd.C
Original file line number Diff line number Diff line change
Expand Up @@ -178,8 +178,6 @@ errlHndl_t mboxRead(TARGETING::Target* i_target,void *o_buffer,
if ((l_IntReg[0] & MBOX_DOORBELL_ERROR) ==
MBOX_DOORBELL_ERROR)
{
TRACFCOMP(g_trac_mbox, INFO_MRK
"mboxRead> Found interrupt on error status register");
// Go get the error info
l_err = mboxGetErrStat(i_target,l_stat);

Expand Down Expand Up @@ -561,6 +559,8 @@ errlHndl_t mboxGetErrStat(TARGETING::Target* i_target,uint64_t &o_status)
}
else
{
TRACFCOMP(g_trac_mbox, INFO_MRK "mboxRead> Found error in pib status register (MBOX_DB_ERR_STAT_PIB): 0x%lx", l_64bitBuf[0]);

//Check for Illegal Op
if ((l_64bitBuf[0] & MBOX_ILLEGAL_OP) ==
MBOX_ILLEGAL_OP)
Expand Down

0 comments on commit 0aed8ab

Please sign in to comment.