Skip to content

Commit

Permalink
p9_{mem,sbe_chiplet}_pll_setup: Level 3
Browse files Browse the repository at this point in the history 
Merge these procedures' error XML into one because they both
need the same FFDC and handling anyway.

Change-Id: Id96af77aaf832be412aba18a5a7e10ee4bc90e5d
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41230
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: Joachim Fenkes <fenkes@de.ibm.com>
Reviewed-by: RAJA DAS <rajadas2@in.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41233
Reviewed-by: Hostboot Team <hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
@fenkes-ibm @dcrowell77
fenkes-ibm authored and dcrowell77 committed Jun 30, 2017
1 parent 542f9ed commit 0e89cd3
Show file tree
Hide file tree
Showing 3 changed files with 84 additions and 38 deletions.
10 changes: 6 additions & 4 deletions src/import/chips/p9/procedures/hwp/perv/p9_mem_pll_setup.C
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2016 */
/* Contributors Listed Below - COPYRIGHT 2015,2017 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand All @@ -31,7 +31,7 @@
// *HWP HW Backup Owner : Srinivas V Naga <srinivan@in.ibm.com>
// *HWP FW Owner : Sunil Kumar <skumar8j@in.ibm.com>
// *HWP Team : Perv
// *HWP Level : 2
// *HWP Level : 3
// *HWP Consumed by : HB
//------------------------------------------------------------------------------

Expand Down Expand Up @@ -103,8 +103,10 @@ fapi2::ReturnCode p9_mem_pll_setup(const fapi2::Target<fapi2::TARGET_TYPE_PROC_C
FAPI_TRY(fapi2::getScom(l_chplt_trgt, PERV_PLL_LOCK_REG,
l_data64)); //l_read_reg = PERV.PLL_LOCK_REG
FAPI_ASSERT(l_data64.getBit<0>() == 1,
fapi2::MEM_PLL_LOCK_ERR()
.set_MEM_PLL_READ(l_data64),
fapi2::PLL_LOCK_ERR()
.set_TARGET_CHIPLET(l_chplt_trgt)
.set_TARGET_CHIP(i_target_chip)
.set_PLL_READ(l_data64),
"ERROR:MEM PLL LOCK NOT SET");

FAPI_DBG("Drop PLL Bypass");
Expand Down
34 changes: 0 additions & 34 deletions src/import/chips/p9/procedures/xml/error_info/p9_mem_pll_setup_errors.xml
View file

This file was deleted.

78 changes: 78 additions & 0 deletions src/import/chips/p9/procedures/xml/error_info/p9_sbe_pll_setup_errors.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,78 @@
<!-- IBM_PROLOG_BEGIN_TAG -->
<!-- This is an automatically generated prolog. -->
<!-- -->
<!-- $Source: src/import/chips/p9/procedures/xml/error_info/p9_sbe_pll_setup_errors.xml $ -->
<!-- -->
<!-- OpenPOWER HostBoot Project -->
<!-- -->
<!-- Contributors Listed Below - COPYRIGHT 2015,2017 -->
<!-- [+] International Business Machines Corp. -->
<!-- -->
<!-- -->
<!-- Licensed under the Apache License, Version 2.0 (the "License"); -->
<!-- you may not use this file except in compliance with the License. -->
<!-- You may obtain a copy of the License at -->
<!-- -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or -->
<!-- implied. See the License for the specific language governing -->
<!-- permissions and limitations under the License. -->
<!-- -->
<!-- IBM_PROLOG_END_TAG -->
<!-- This is an automatically generated file. -->
<!-- File: p9_sbe_chiplet_pll_setup_errors.xml. -->
<!-- Halt codes for p9_sbe_chiplet_pll_setup -->
<hwpErrors>
<sbeTarget>TARGET_CHIP</sbeTarget>
<!-- ******************************************************************** -->
<hwpError>
<sbeError/>
<rc>RC_PLL_LOCK_ERR</rc>
<description>PLL Lock Not set</description>
<ffdc>TARGET_CHIPLET</ffdc>
<ffdc>PLL_READ</ffdc>
<collectRegisterFfdc>
<id>NET_CTRL_REGISTERS</id>
<target>TARGET_CHIPLET</target>
<targetType>TARGET_TYPE_PERV</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>CPLT_CTRL_REGISTERS</id>
<target>TARGET_CHIPLET</target>
<targetType>TARGET_TYPE_PERV</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>PLL_LOCK_REG</id>
<target>TARGET_CHIPLET</target>
<targetType>TARGET_TYPE_PERV</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>ROOT_CTRL_REGISTERS</id>
<target>TARGET_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<collectRegisterFfdc>
<id>PERV_CTRL_REGISTERS</id>
<target>TARGET_CHIP</target>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
</collectRegisterFfdc>
<callout>
<target>TARGET_CHIPLET</target>
<priority>HIGH</priority>
</callout>
<callout>
<procedure>CODE</procedure>
<priority>MEDIUM</priority>
</callout>
<deconfigure>
<target>TARGET_CHIPLET</target>
</deconfigure>
<gard>
<target>TARGET_CHIPLET</target>
</gard>
</hwpError>
<!-- ******************************************************************** -->
</hwpErrors>

0 comments on commit 0e89cd3

Please sign in to comment.