Skip to content

Commit

Permalink
Tweaks to traces for runtime error handling
Browse files Browse the repository at this point in the history
Change-Id: I64a7b74852f663a6ed7267da3b973298d90d3be2
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66543
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Richard Ward <rward15@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
dcrowell77 authored and wghoffa committed Oct 18, 2018
1 parent a515f16 commit 18413b3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
5 changes: 3 additions & 2 deletions src/usr/fsiscom/runtime/rt_fsiscom.C
Original file line number Diff line number Diff line change
Expand Up @@ -395,7 +395,8 @@ static std::map<TARGETING::Target *, std::map<uint64_t, uint64_t>> g_scomCache;
*/
void switchToFspScomAccess(TARGETING::TargetHandle_t i_target)
{
TRACDCOMP(g_trac_fsiscom,ENTER_MRK"switchToFspScomAccess");
TRACFCOMP(g_trac_fsiscom,ENTER_MRK"switchToFspScomAccess : %.8X",
TARGETING::get_huid(i_target));
errlHndl_t l_err = NULL;

// Need to mark the target's DMI channel and all targets below it
Expand Down Expand Up @@ -508,7 +509,7 @@ void switchToFspScomAccess(TARGETING::TargetHandle_t i_target)
g_scomCache[l_membuf] = l_newmap;
}

TRACDCOMP(g_trac_fsiscom,EXIT_MRK"switchToFspScomAccess");
TRACFCOMP(g_trac_fsiscom,EXIT_MRK"switchToFspScomAccess");
}


Expand Down
4 changes: 2 additions & 2 deletions src/usr/util/runtime/rt_fwreq_helper.C
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ errlHndl_t firmware_request_helper(uint64_t i_reqLen, void *i_req,
{
TRACFCOMP(g_trac_runtime,
"FSP is doing a reset/reload, "
"doing a VPD write failed. "
"sending a message to the FSP failed. "
"retry:%d/%d, rc:%d, io_type:%d, dataSize:%d, "
"seqnum:0x%X, msgq:0x%X, msgType:0x%X, __req:%d, "
"__onlyError:%d",
Expand Down Expand Up @@ -372,7 +372,7 @@ errlHndl_t firmware_request_helper(uint64_t i_reqLen, void *i_req,
case hostInterfaces::HBRT_FW_MSG_HBRT_FSP_REQ:
{
TRACFCOMP(g_trac_runtime,
ERR_MRK"Failed doing a VPD write. "
ERR_MRK"Failed sending a message to the FSP. "
"rc:%d, io_type:%d, dataSize:%d, "
"seqnum:0x%X, msgq:0x%X, msgType:0x%X, __req:%d, "
"__onlyError:%d",
Expand Down

0 comments on commit 18413b3

Please sign in to comment.