Skip to content

Commit

Permalink
Ensure we collect PPE trace if psu op times out
Browse files Browse the repository at this point in the history
There was a bug in the code where if we are running on a FSP system
in simics we will not run the magic instruction to capture PPE trace
at the time of the psu op timeout. This commit insures we will call
sbe-trace and save the simics console output to file for later debug
this will help with the defect listed in this commit.

Change-Id: I7caa776f06197f7732a5dcabdcc01a3b91cdfba3
CQ: SW444734
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65992
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Ilya Smirnov <ismirno@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
crgeddes authored and wghoffa committed Sep 12, 2018
1 parent 7c5afbd commit 192ca8a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/usr/sbeio/sbe_psudd.C
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,10 @@ errlHndl_t SbePsu::pollForPsuComplete(TARGETING::Target * i_target,
}
psuResponse* l_resp = reinterpret_cast<psuResponse*>(l_respRegs);

// Collect SBE traces in simics
MAGIC_INST_GET_SBE_TRACES(i_target->getAttr<TARGETING::ATTR_POSITION>(),
SBEIO_PSU_RESPONSE_TIMEOUT);

if(!(l_resp->primaryStatus & SBE_PRI_FFDC_ERROR))
{
SBE_TRACF("Error: PSU Timeout and no FFDC present");
Expand Down Expand Up @@ -912,10 +916,6 @@ errlHndl_t SbePsu::pollForPsuComplete(TARGETING::Target * i_target,
l_errl->collectTrace(SBEIO_COMP_NAME);
}

MAGIC_INST_GET_SBE_TRACES(
i_target->getAttr<TARGETING::ATTR_POSITION>(),
SBEIO_PSU_RESPONSE_TIMEOUT);

break;
}

Expand Down

0 comments on commit 192ca8a

Please sign in to comment.