Skip to content

Commit

Permalink
Fixed Maint IUE unmasked with mnfg flags
Browse files Browse the repository at this point in the history
Change-Id: I33eb20071e2b694bdaac9e1d625a08138ecfa360
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53319
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53497
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Matthickman14 authored and dcrowell77 committed Mar 8, 2018
1 parent 3877eea commit 1b11547
Showing 1 changed file with 4 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,11 +63,12 @@ fapi2::ReturnCode after_memdiags( const fapi2::Target<TARGET_TYPE_MCBIST>& i_tar
{
fapi2::ReturnCode l_rc;
fapi2::buffer<uint64_t> dsm0_buffer;
fapi2::buffer<uint64_t> l_mnfg_buffer;
uint64_t rd_tag_delay = 0;
uint64_t wr_done_delay = 0;
uint64_t mnfg_flag = 0;
fapi2::buffer<uint64_t> l_aue_buffer;
fapi2::ATTR_CHIP_EC_FEATURE_HW414700_Type l_checkstop_flag;
constexpr uint64_t MNFG_THRESHOLDS_ATTR = 63;

// Broadcast mode workaround for UEs causing out of sync
FAPI_TRY(mss::workarounds::mcbist::broadcast_out_of_sync(i_target, mss::ON));
Expand Down Expand Up @@ -104,9 +105,9 @@ fapi2::ReturnCode after_memdiags( const fapi2::Target<TARGET_TYPE_MCBIST>& i_tar
}

// If MNFG FLAG Threshhold is enabled skip IUE unflagging
FAPI_TRY (mss::mnfg_flags(mnfg_flag) );
FAPI_TRY ( mss::mnfg_flags(l_mnfg_buffer) );

if (mnfg_flag != fapi2::ENUM_ATTR_MNFG_FLAGS_MNFG_THRESHOLDS)
if ( !(l_mnfg_buffer.getBit<MNFG_THRESHOLDS_ATTR>()) )
{
l_ecc64_fir_reg.recoverable_error<MCA_FIR_MAINTENANCE_IUE>();
}
Expand Down

0 comments on commit 1b11547

Please sign in to comment.