Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement Static Analysis with cppcheck
Cppcheck static analysis tool can now be run when compiling by running: make cppcheck And it will always run when committing without stopping the commit if an error is found. This commit suppresses some false positives found in the code. A false positive can be suppressed inline by placing “// cppcheck-suppress syntaxError” in a line before the false positive., e.g.: char arr[5]; // cppcheck-suppress arrayIndexOutOfBounds arr[10] = 0; Change-Id: I9e833a153d6b04df2f8a72cd994e43922c61c2fe RTC: 201451 Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/79629 Reviewed-by: Zachary Clark <zach@ibm.com> Reviewed-by: Nicholas E Bofferding <bofferdn@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
- Loading branch information
1 parent
bafe5de
commit 1d4530d
Showing
15 changed files
with
265 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -23,3 +23,5 @@ gcov_report | |
lcov_data | ||
standalone/ | ||
objdump/ | ||
*.cppcheck | ||
cpptools/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
#!/bin/bash | ||
# IBM_PROLOG_BEGIN_TAG | ||
# This is an automatically generated prolog. | ||
# | ||
# $Source: src/build/citest/etc/cppcheck $ | ||
# | ||
# OpenPOWER HostBoot Project | ||
# | ||
# Contributors Listed Below - COPYRIGHT 2019 | ||
# [+] International Business Machines Corp. | ||
# | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
# implied. See the License for the specific language governing | ||
# permissions and limitations under the License. | ||
# | ||
# IBM_PROLOG_END_TAG | ||
|
||
export CPPCHECK_COMMIT="4939e0c3086151033bd491bb2df72f7728a4c037" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
#!/bin/bash -e | ||
# IBM_PROLOG_BEGIN_TAG | ||
# This is an automatically generated prolog. | ||
# | ||
# $Source: src/build/tools/build-cppcheck $ | ||
# | ||
# OpenPOWER HostBoot Project | ||
# | ||
# Contributors Listed Below - COPYRIGHT 2019 | ||
# [+] International Business Machines Corp. | ||
# | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or | ||
# implied. See the License for the specific language governing | ||
# permissions and limitations under the License. | ||
# | ||
# IBM_PROLOG_END_TAG | ||
|
||
source $PROJECT_ROOT/src/build/citest/etc/cppcheck | ||
|
||
update_toolconfig(){ | ||
echo "commit: $CPPCHECK_COMMIT" | ||
echo "gcc version: $(gcc -dumpversion)" | ||
echo "S: $(uname -o)" | ||
echo "arch: $(uname -m)" | ||
echo "$(lsb_release -i)" | ||
echo "$(lsb_release -r)" | ||
} | ||
|
||
if [ -n "${OPENPOWER_BUILD}" ]; then | ||
exit | ||
fi | ||
|
||
cd $PROJECT_ROOT/src/build/tools | ||
|
||
if [[ ! -d "cpptools" ]]; then | ||
mkdir cpptools | ||
fi | ||
|
||
cd cpptools | ||
if [[ ! -d "cppcheck" ]]; then | ||
# cppcheck folder does not exist, clone repo for the first time | ||
git clone git@github.com:danmar/cppcheck.git | ||
cd cppcheck | ||
git reset --hard $CPPCHECK_COMMIT #update to cppcheck commit | ||
update_toolconfig >.cpp_toollevel | ||
SHOULDMAKE=1 | ||
else | ||
cd cppcheck | ||
if ! cmp -s .cpp_toollevel <(update_toolconfig) ; then | ||
# cppcheck repo is not at the | ||
# level set in $PROJECT_ROOT/src/build/citest/etc/cppcheck | ||
if ! git fetch origin; then | ||
cd $PROJECT_ROOT/src/build/tools/cpptools | ||
rm -rf cppcheck | ||
git clone git@github.com:danmar/cppcheck.git | ||
cd cppcheck | ||
fi | ||
git reset --hard $CPPCHECK_COMMIT | ||
update_toolconfig >.cpp_toollevel | ||
|
||
SHOULDMAKE=1 | ||
fi | ||
if [[ ! -f "cppcheck" ]]; then | ||
SHOULDMAKE=1 | ||
fi | ||
fi | ||
|
||
if [ "${SHOULDMAKE}" ]; then | ||
|
||
# Check if CXX is set, if it is not then try to find it with CXXPATH | ||
# if CXXPATH does not exist, default to host's g++ | ||
if [ -z "$CXX" ]; then | ||
if [ -z "${CXXPATH}" ]; then | ||
export CXX=g++ | ||
else | ||
export CXX=${CXXPATH}/g++ | ||
fi | ||
fi | ||
|
||
make | ||
|
||
fi | ||
|
||
cd $PROJECT_ROOT | ||
|
||
|
Oops, something went wrong.