Skip to content

Commit

Permalink
Moving Sbe Retry Handler work to common file for runtime
Browse files Browse the repository at this point in the history
We want to move the sbe_retry_handler.C and other files
associated with it to a common directory and makefile.

Change-Id: Ifc725709d23d9eec75d2f91b2be73728c91a8d86
RTC:180241
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53591
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Martin Gloff <mgloff@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
e-liner authored and dcrowell77 committed Feb 15, 2018
1 parent 77b70bb commit 1e337a9
Show file tree
Hide file tree
Showing 5 changed files with 39 additions and 10 deletions.
26 changes: 26 additions & 0 deletions src/usr/sbeio/common/common.mk
@@ -0,0 +1,26 @@
# IBM_PROLOG_BEGIN_TAG
# This is an automatically generated prolog.
#
# $Source: src/usr/sbeio/common/common.mk $
#
# OpenPOWER HostBoot Project
#
# Contributors Listed Below - COPYRIGHT 2018
# [+] International Business Machines Corp.
#
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
# implied. See the License for the specific language governing
# permissions and limitations under the License.
#
# IBM_PROLOG_END_TAG
SBEIO_COMMON_OBJS += sbe_attn.o
SBEIO_COMMON_OBJS += sbe_retry_handler.o
4 changes: 2 additions & 2 deletions src/usr/sbeio/sbe_attn.C → src/usr/sbeio/common/sbe_attn.C
@@ -1,11 +1,11 @@
/* IBM_PROLOG_BEGIN_TAG */
/* This is an automatically generated prolog. */
/* */
/* $Source: src/usr/sbeio/sbe_attn.C $ */
/* $Source: src/usr/sbeio/common/sbe_attn.C $ */
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2017 */
/* Contributors Listed Below - COPYRIGHT 2017,2018 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down
@@ -1,7 +1,7 @@
/* IBM_PROLOG_BEGIN_TAG */
/* This is an automatically generated prolog. */
/* */
/* $Source: src/usr/sbeio/sbe_retry_handler.C $ */
/* $Source: src/usr/sbeio/common/sbe_retry_handler.C $ */
/* */
/* OpenPOWER HostBoot Project */
/* */
Expand Down Expand Up @@ -300,7 +300,9 @@ void SbeRetryHandler::main_sbe_handler( TARGETING::Target * i_target )
// In the informational only mode, we just need enough information
// to get the SBE RC returned from the HWP. We are running with
// the knowledge that the SBE has failed already.
this->sbe_boot_fail_handler(i_target, true); // pass true to have log show up

// pass true to have log show up
this->sbe_boot_fail_handler(i_target, true);
this->iv_currentSBEState = SBE_FAILED_TO_BOOT;
}

Expand Down
5 changes: 3 additions & 2 deletions src/usr/sbeio/makefile
Expand Up @@ -25,6 +25,7 @@
ROOTPATH = ../../..
PROCEDURES_PATH = ${ROOTPATH}/src/import/chips/p9/procedures
MODULE = sbeio
include common/common.mk

EXTRAINCDIR += ${ROOTPATH}/src/import/hwpf/fapi2/include
EXTRAINCDIR += ${ROOTPATH}/src/include/usr/fapi2
Expand Down Expand Up @@ -55,11 +56,11 @@ OBJS += sbe_getSBEFFDC.o
OBJS += sbe_memRegionMgr.o
OBJS += sbe_fifo_buffer.o
OBJS += sbe_ffdc_package_parser.o
OBJS += sbe_attn.o
OBJS += sbe_retry_handler.o
OBJS += ${SBEIO_COMMON_OBJS}

VPATH += ${ROOTPATH}/src/import/chips/p9/procedures/hwp/perv/
VPATH += ${ROOTPATH}/src/import/chips/p9/procedures/hwp/lib/
VPATH += ${ROOTPATH}/src/usr/sbeio/common

include ${ROOTPATH}/procedure.rules.mk

Expand Down
8 changes: 4 additions & 4 deletions src/usr/sbeio/runtime/makefile
Expand Up @@ -31,7 +31,7 @@ PROCEDURES_PATH = ${ROOTPATH}/src/import/chips/p9/procedures

MODULE = sbeio_rt


include ../common/common.mk

EXTRAINCDIR += ${ROOTPATH}/src/import/hwpf/fapi2/include
EXTRAINCDIR += ${ROOTPATH}/src/include/usr/fapi2
Expand All @@ -47,13 +47,13 @@ EXTRAINCDIR += ${PROCEDURES_PATH}/hwp/sbe/
## Objects unique to HBRT
OBJS += rt_sbeio.o
OBJS += sbeio_attr_override.o
OBJS += sbe_attn.o
OBJS += sbe_retry_handler.o
#@todo - RTC:180241 - Add in error handlers by creating common mk
OBJS += ${SBEIO_COMMON_OBJS}

VPATH += ${ROOTPATH}/src/import/chips/p9/procedures/hwp/perv/
VPATH += ${ROOTPATH}/src/import/chips/p9/procedures/hwp/sbe/
VPATH += ${ROOTPATH}/src/import/chips/p9/procedures/hwp/lib/
VPATH += ../common

include ${ROOTPATH}/procedure.rules.mk
include ${ROOTPATH}/src/import/chips/p9/procedures/hwp/sbe/p9_get_sbe_msg_register.mk
include ${ROOTPATH}/src/import/chips/p9/procedures/hwp/perv/p9_start_cbs.mk
Expand Down

0 comments on commit 1e337a9

Please sign in to comment.