Skip to content

Commit

Permalink
Remove vin_bulk check before status clears in pmic_enable
Browse files Browse the repository at this point in the history
The VIN_BULK bit of R08 used to update live, either that
or it just never updated at all. Either way, the bit gets stuck
in a stale error state now, and since it's checked before the
error bits are cleared, the clears never actually occur,
leaving stale errors that are killing isteps

Change-Id: Ib10de516554fd3e95cf9c09f5e6a0ab62fdd340f
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87958
Dev-Ready: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87964
Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Christian R Geddes <crgeddes@us.ibm.com>
  • Loading branch information
markypizz authored and crgeddes committed Dec 3, 2019
1 parent d277b5e commit 2917689
Showing 1 changed file with 0 additions and 3 deletions.
Expand Up @@ -533,9 +533,6 @@ fapi2::ReturnCode disable_and_reset_pmics(const std::vector<fapi2::Target<fapi2:

for (const auto& l_pmic : i_pmics)
{
// Make sure PMIC is alive
FAPI_TRY(mss::pmic::poll_for_pbulk_good(l_pmic));

// First, disable
{
fapi2::buffer<uint8_t> l_reg_contents;
Expand Down

0 comments on commit 2917689

Please sign in to comment.