Skip to content

Commit

Permalink
Adds lab PDA support
Browse files Browse the repository at this point in the history
Change-Id: Iea85858e918ddf2d5ba641e1c494eee6e50f91c2
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/49650
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/51097
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
esteban012 authored and crgeddes committed Dec 22, 2017
1 parent 3440e65 commit 296cd58
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/import/chips/p9/procedures/hwp/memory/lib/dimm/ddr4/pda.C
Expand Up @@ -254,7 +254,7 @@ fapi2::ReturnCode add_enable( const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_ta
// Overrides the PDA value to be enabled
l_mrs03.iv_pda = fapi2::ENUM_ATTR_EFF_PER_DRAM_ACCESS_ENABLE;

FAPI_TRY( mss::mrs_engine(i_target, l_mrs03, i_rank, DELAY, io_inst) );
FAPI_TRY( mss::mrs_engine(i_target, l_mrs03, i_rank, mss::ddr4::pda::SAFE_COMMAND_DELAY, io_inst) );

fapi_try_exit:
return fapi2::current_err;
Expand Down Expand Up @@ -306,7 +306,7 @@ fapi2::ReturnCode add_disable( const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_t
// Overrides the PDA value to be disabled
l_mrs03.iv_pda = fapi2::ENUM_ATTR_EFF_PER_DRAM_ACCESS_DISABLE;

FAPI_TRY( mss::mrs_engine(i_target, l_mrs03, i_rank, DELAY, io_inst) );
FAPI_TRY( mss::mrs_engine(i_target, l_mrs03, i_rank, mss::ddr4::pda::SAFE_COMMAND_DELAY, io_inst) );

fapi_try_exit:
return fapi2::current_err;
Expand Down
Expand Up @@ -67,7 +67,7 @@ enum consts : uint64_t
// 10 cycles for safety
SAFETY = 10,
// Total delay is your register max + safety
DELAY = MAX_PDA_REG + SAFETY,
SAFE_COMMAND_DELAY = MAX_PDA_REG + SAFETY,

// PDA on/off settings
START_DELAY_VALUE = 0,
Expand Down

0 comments on commit 296cd58

Please sign in to comment.