Skip to content

Commit

Permalink
Reload OCC and HCODE LIDs in OCC Reload Path
Browse files Browse the repository at this point in the history
We unload the OCC and HCODE lids during OCC reload code
path, which causes their size to be set to 0 in PNOR. However,
we don't reload the lids, so the size is never updated
in PNOR, and the incorrect size of 0 is reported when OCC
tries to restart. The fix is to explicitly reload OCC and
HCODE lids before requesting the size from PNOR.

Change-Id: Ib0ea6336d8c87ecc8a93d7f55f10acea7c8a13f4
CQ: SW416143
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/54381
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Ilya Smirnov authored and dcrowell77 committed Feb 27, 2018
1 parent d6d4025 commit 299023e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/usr/util/utillidmgr.C
Original file line number Diff line number Diff line change
Expand Up @@ -683,7 +683,8 @@ errlHndl_t UtilLidMgr::getStoredLidImage(void*& o_pLidImage,
}
else
{
if(0 == iv_lidImageSize)
errl = updateLid(iv_lidId);
if(0 == iv_lidImageSize && errl == nullptr)
{
errl = getLidSize(iv_lidImageSize);
}
Expand Down

0 comments on commit 299023e

Please sign in to comment.