Skip to content

Commit

Permalink
Add ASSERT trace buffer to task crash log
Browse files Browse the repository at this point in the history
A common cause of task crashes is an explicit assert.  Without
full traces we can't differentiate an assert from a nullptr error,
and we don't know which line failed.  This will add the ASSERT
trace to the error log that gets created for any task crash.

Change-Id: Ieaccf74ab7c8688109b80b0e22818e45cfdb8028
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72557
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dcrowell77 committed Mar 19, 2019
1 parent d7910f6 commit 2c2978d
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/usr/initservice/baseinitsvc/initservice.C
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2011,2018 */
/* Contributors Listed Below - COPYRIGHT 2011,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -438,6 +438,9 @@ errlHndl_t InitService::executeFn(
l_tidretrc,
l_childsts );

l_errl->collectTrace("ASSERT",128);
l_errl->collectTrace("INITSVC",512);

// break out of do block
break;
} // endif tidretrc
Expand Down

0 comments on commit 2c2978d

Please sign in to comment.