Skip to content

Commit

Permalink
Do not allow PNOR partition adjustments when not in test mode
Browse files Browse the repository at this point in the history
In some cases we were seeing confusing error messages while
building pnor images in op-build that pointed at the wrong
partition being the problem.  This was caused by some logic
that automatically adjusts the size of the HBI partition to
handle our testcase environment.

Change-Id: Ib6089ca9a0c68d4c8814fe7a36404096b42837b7
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/82952
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zachary Clark <zach@ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
dcrowell77 authored and wghoffa committed Sep 12, 2019
1 parent 26c32cb commit 2ceefa0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/build/buildpnor/PnorUtils.pm
Expand Up @@ -431,7 +431,7 @@ sub checkSpaceConstraints
{
# If this is a test run increase HBI size by PAGE_SIZE until all test
# cases fit
if ($eyeCatch eq "HBI")
if ( $testRun && ($eyeCatch eq "HBI") )
{
print "Adjusting HBI size - ran out of space for test cases\n";
adjustSecPhysSize(\%sectionHash, $layoutKey, $filesize);
Expand Down

0 comments on commit 2ceefa0

Please sign in to comment.