Skip to content

Commit

Permalink
Cleanup minor code review nits from SW433868.
Browse files Browse the repository at this point in the history
Change-Id: I595fdcecaa08830514dacd81255bc0e9af222b40
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/61964
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
rward15 authored and dcrowell77 committed Jan 14, 2019
1 parent 37132b7 commit 2d410b6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/include/usr/sbeio/sbe_psudd.H
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ class SbePsu
* function will record the error state so it can be reported later.
*
*
* @param[in] i_plid Program log id for the error
* @param[in] i_plid Platform log id for the error
* @param[in] i_target Proc target for PSU Request that caused an error
*/
void saveEarlyError(uint32_t i_plid,TARGETING::TargetHandle_t i_target);
Expand Down
10 changes: 2 additions & 8 deletions src/usr/sbeio/sbe_psudd.C
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
trace_desc_t* g_trac_sbeio;
TRAC_INIT(&g_trac_sbeio, SBEIO_COMP_NAME, 6*KILOBYTE, TRACE::BUFFER_SLOW);

// used to uniquley identify the SBE PSU message queue
// used to uniquely identify the SBE PSU message queue
const char* SBE_PSU_MSG_Q = "sbepsuq";

#define SBE_TRACF(printf_string,args...) \
Expand Down Expand Up @@ -332,12 +332,6 @@ errlHndl_t SbePsu::performPsuChipOp(TARGETING::Target * i_target,

/**
* @brief record info from an "early" error so it can be reported later
*
* If an error occurs before the fapi2 library is loaded, this function
* can be used to record the details for later reporting.
*
* @param[in] i_plid Program log id for the error
* @param[in] i_target Proc target for PSU Request that caused error
*/
void SbePsu::saveEarlyError(uint32_t i_plid, TARGETING::TargetHandle_t i_target)
{
Expand All @@ -347,7 +341,7 @@ void SbePsu::saveEarlyError(uint32_t i_plid, TARGETING::TargetHandle_t i_target)
iv_earlyErrorPlid = i_plid;
iv_earlyErrorTarget = i_target;

SBE_TRACD(ENTER_MRK "saveEarlyError");
SBE_TRACD(EXIT_MRK "saveEarlyError");
}

/**
Expand Down

0 comments on commit 2d410b6

Please sign in to comment.