Skip to content

Commit

Permalink
istepdispatcher: When trying to set the watchdog, clear DONT_STOP
Browse files Browse the repository at this point in the history
We intend to actually stop the watchdog so allow the set command stop it
as defined in the IPMI spec.

Resolves #137

Signed-off-by: William A. Kennington III <wak@google.com>
Change-Id: I07152602dd0c03c0224a20e5bea3d4ff804fc093
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/58546
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
wak-google authored and dcrowell77 committed May 19, 2018
1 parent 4d392ef commit 2f1a0ed
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/usr/initservice/istepdispatcher/istepdispatcher.C
Original file line number Diff line number Diff line change
Expand Up @@ -2888,9 +2888,7 @@ void IStepDispatcher::istepPauseSet(uint8_t i_step, uint8_t i_substep)
#ifdef CONFIG_BMC_IPMI
errlHndl_t err_ipmi = IPMIWATCHDOG::setWatchDogTimer(
IPMIWATCHDOG::DEFAULT_WATCHDOG_COUNTDOWN,
static_cast<uint8_t>
(IPMIWATCHDOG::DO_NOT_STOP |
IPMIWATCHDOG::BIOS_FRB2), // default
IPMIWATCHDOG::BIOS_FRB2,
IPMIWATCHDOG::NO_ACTIONS); // do nothing when
// timeout occurs
if(err_ipmi)
Expand Down

0 comments on commit 2f1a0ed

Please sign in to comment.