Skip to content

Commit

Permalink
Always have secureModeDisable bit set to 0 in sbe_retry_handler
Browse files Browse the repository at this point in the history
After talking with the HWP writers for the sbe_extract_rc HWP they
told us we should always act like the secureModeDisable bit is false.
The only reason that option is there is for lab use and we shouldnt
ever use it. This commit makes that bit always 0

Change-Id: Id781df3a95ffdf5ec82624aebe6830f17d7dcf2b
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/52861
Reviewed-by: Elizabeth K. Liner <eliner@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Feb 4, 2018
1 parent 70ec114 commit 32a0511
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/include/usr/sbeio/sbe_retry_handler.H
Expand Up @@ -285,6 +285,10 @@ class SbeRetryHandler
/*
* @brief Bit used for testing in the lab with systems that have secure
* mode disabled.
* NOTE: This bit is only used in the lab when running this HWP with cronus.
* We offered to have this bit set in FW based on the security settings of the
* system HW people told us it would be safer for us to always assume this bit
* is off in FW, so we will leave this bit as 0 until the HW devs tell us to use it.
*/
bool iv_secureModeDisabled;

Expand Down
2 changes: 1 addition & 1 deletion src/usr/sbeio/sbe_retry_handler.C
Expand Up @@ -90,7 +90,7 @@ SbeRetryHandler::SbeRetryHandler(SBE_MODE_OF_OPERATION i_sbeMode,
uint32_t i_plid)

: iv_useSDB(false)
, iv_secureModeDisabled(!SECUREBOOT::enabled())
, iv_secureModeDisabled(false) //Per HW team this should always be 0
, iv_sbeRestarted(false)
, iv_sbeSide(0)
, iv_errorLogPLID(0)
Expand Down

0 comments on commit 32a0511

Please sign in to comment.