Skip to content

Commit

Permalink
Fix getChildByAffinity call in mmio.C and add more traces
Browse files Browse the repository at this point in the history
There was a bug in mmio.C where we are trying to find the ocmb targets
associated with a proc. We are looking up UNITs which is wrong because
OCMBs are CHIPs so this commit addresses that. Also this commit elevates
some debug traces to real traces to help with bringup.

Change-Id: I9c11ca4a30c24192955474148cf4e61cca16489c
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/72964
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Corey V. Swenson <cswenson@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Mar 8, 2019
1 parent ce4004d commit 3b02a6a
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions src/usr/mmio/mmio.C
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ errlHndl_t mmioSetup()
{
errlHndl_t l_err = nullptr;

TRACDCOMP(g_trac_mmio, ENTER_MRK"mmioSetup");
TRACFCOMP(g_trac_mmio, ENTER_MRK"mmioSetup");
// called from istep 12.3

do
Expand All @@ -80,7 +80,7 @@ errlHndl_t mmioSetup()
getAllChiplets(l_omiTargetList, TARGETING::TYPE_OMI);
if (l_omiTargetList.size() == 0)
{
TRACDCOMP(g_trac_mmio,
TRACFCOMP(g_trac_mmio,
INFO_MRK"mmioSetup: Exiting, non-OMI system");
break;
}
Expand Down Expand Up @@ -170,7 +170,7 @@ errlHndl_t mmioSetup()
TARGETING::TargetHandleList l_ocmbTargetList;
l_ocmbTargetList.clear();
getChildAffinityTargets(l_ocmbTargetList, l_procTarget,
TARGETING::CLASS_UNIT, TARGETING::TYPE_OCMB_CHIP);
TARGETING::CLASS_CHIP, TARGETING::TYPE_OCMB_CHIP);
for (auto & l_ocmbTarget: l_ocmbTargetList)
{
uint64_t l_ocmbVmAddr = 0;
Expand All @@ -192,7 +192,7 @@ errlHndl_t mmioSetup()
}
} while(0);

TRACDCOMP(g_trac_mmio, EXIT_MRK"mmioSetup");
TRACFCOMP(g_trac_mmio, EXIT_MRK"mmioSetup");

return l_err;
}
Expand Down

0 comments on commit 3b02a6a

Please sign in to comment.