Skip to content

Commit

Permalink
Only display ERRL user details callouts/strings when dumping error to…
Browse files Browse the repository at this point in the history
… console

This commit fixes a bug wherein, when Hostboot dumped an error log to the
console that contained user details with the same subsection ID as an ERRL
string but for a different component ID, the information, which was often in
binary format, would appear garbled, and would additionally terminate the BMC's
SOL session due to invalid characters.  The change narrows the scope of what
gets emitted to just ERRL component strings/callouts.

Change-Id: Ifbe83448a56955d44f0e775e123ffb95a6330b8a
CQ: SW463437
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/76392
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Nick Bofferding authored and dcrowell77 committed Apr 25, 2019
1 parent 387ed5a commit 3df3c9b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/usr/errldisplay/errldisplay.C
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2013,2017 */
/* Contributors Listed Below - COPYRIGHT 2013,2019 */
/* [+] Google Inc. */
/* [+] International Business Machines Corp. */
/* */
Expand Down Expand Up @@ -701,7 +701,7 @@ void ErrLogDisplay::msgDisplay (const errlHndl_t &i_err,
displayHwpf( user_data->iv_pData, user_data->iv_Size,
user_data->iv_header.iv_sst);
}
else
else if(user_data->iv_header.iv_compId == ERRL_COMP_ID)
{
switch ( user_data->iv_header.iv_sst )
{
Expand Down

0 comments on commit 3df3c9b

Please sign in to comment.