Skip to content

Commit

Permalink
PM: refine enablement attributes for advanced functions (VDM,RESCLK,W…
Browse files Browse the repository at this point in the history
…OF,IVRM)

- Move to a "disable feature" attribute paradigm for SYSTEM control
- Add consistent system enablement (eg Cronus, MRW) control attributes
- Added HWP attributes to allow p9_pstate_parameter_block to indicate
  validation status to p9_hcode_image_build for Hcode header updates
- Mark attributes as deprecated for future removal
- Added HB system defaults to auto enable RESCLK, VDM and WOF.  IVRM is
  disabled.
    - RESCLK only has override attributes so will enable function once code
      that looks the attributes is in a driver
    - VDM enablement forces the need for #W to be there and valid.  Valid will
      be if #W is all zero, disable VDMs;  if any of #W is non-zerom, failing
      validity checks (non-decreasing VID Compares) will fail the IPL.
    - WOF enablement needs IQ to fill out the OCC parameter block.  If
      not present, WOF is disabled.  Longer term (future commit), RESCLKs and
      VDMs will also gate WOF but not for early development and testing.
- Add a Chip EC attribute to discern the DD levels that WOF is supported
- Move to IVRM vs IVRMS
- Made all *ENABLED HWP attributes PROC_CHIP in scope to avoid collisions from
  multiple chip targets
- Made all HWP attributes writeable
- Deprecate (preped rename) an HWP attribute
- Added throttle control attributes

Change-Id: I527b67c7b3111da6313c22c0af558c23e71da7bf
Original-Change-Id: I5e56a36a9e2a4b3e6964ed66ff5c1013be26ed33
RTC: 173673
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/40063
Dev-Ready: Gregory S. Still <stillgs@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Michael S. Floyd <mfloyd@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: CHRISTOPHER M. RIEDL <cmriedl@us.ibm.com>
Reviewed-by: Matt K. Light <mklight@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55524
CI-Ready: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
stillgs authored and dcrowell77 committed Mar 13, 2018
1 parent 227a32f commit 420c266
Showing 1 changed file with 18 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3619,8 +3619,24 @@
</chip>
</chipEcFeature>
</attribute>

<!-- ******************************************************************** -->
<!-- ******************************************************************** -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_WOF_NOT_SUPPORTED</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Work Load Optimized Frequency non-support in manufacturing.
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
<test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
</attribute>
<!-- ******************************************************************** -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_DD1_ANALOG</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
Expand Down

0 comments on commit 420c266

Please sign in to comment.