Skip to content

Commit

Permalink
Fix bug in attribute sync
Browse files Browse the repository at this point in the history
Deserialization pointer was getting double updated.  This commit
fixes

Change-Id: I41f38633f057bcda93f0ed35500dce034cf55425
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80777
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Reviewed-by: Zachary Clark <zach@ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
sannerd authored and dcrowell77 committed Jul 24, 2019
1 parent 6b03894 commit 449d1fa
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions src/usr/targeting/common/attributeTank.C
Expand Up @@ -443,15 +443,12 @@ void AttributeTank::deserializeAttributes(
// Iterate thru the Attributes
while (l_index < i_attributes.iv_size)
{
// Progress the offset to the serialized data
l_serializedData += l_index;

// Create a new Attribute
Attribute * l_pAttribute = new Attribute();

// Deserialize the data, if possible
uint32_t l_deserializedDataSize = l_pAttribute->deserialize(
l_serializedData,
l_serializedData + l_index,
i_attributes.iv_size - l_index);

if (!l_deserializedDataSize)
Expand Down

0 comments on commit 449d1fa

Please sign in to comment.