Skip to content

Commit

Permalink
Set SBE console enable based on Hostboot config var
Browse files Browse the repository at this point in the history
ATTR_LPC_CONSOLE_CNFG will shadow CONFIG_CONSOLE on
the master proc, always disabled on the slave chips.

Change-Id: Idf7286f91455148856b57ff66450c97862b3506e
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66798
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
dcrowell77 authored and wghoffa committed Oct 4, 2018
1 parent 76ae3d5 commit 459e8bf
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/usr/targeting/common/xmltohb/hb_customized_attrs.xml
Original file line number Diff line number Diff line change
Expand Up @@ -704,6 +704,13 @@
<persistency>volatile-zeroed</persistency>
</attribute>

<!-- Make this writeable so we can choose the value based on our CONFIG -->
<attribute>
<id>ATTR_LPC_CONSOLE_CNFG</id>
<persistency>volatile-zeroed</persistency>
<writeable/>
</attribute>

<!-- This is only enabled for Wafer Test -->
<attribute>
<id>ATTR_START_CBS_FIFO_RESET_SKIP</id>
Expand Down
26 changes: 26 additions & 0 deletions src/usr/targeting/targetservicestart.C
Original file line number Diff line number Diff line change
Expand Up @@ -478,8 +478,34 @@ static void initializeAttributes(TargetService& i_targetService,
}
TARG_INF( "Setting RISK_LEVEL=%d", l_riskLevel );
l_pTopLevel->setAttr<ATTR_RISK_LEVEL>(l_riskLevel);

//Set the SBE Console enablement based on our console enablement
ATTR_LPC_CONSOLE_CNFG_type l_consoleOn = LPC_CONSOLE_CNFG_ENABLE;
#ifdef CONFIG_CONSOLE
l_consoleOn = LPC_CONSOLE_CNFG_DISABLE;
#endif
l_pMasterProcChip->setAttr<ATTR_LPC_CONSOLE_CNFG>(l_consoleOn);

}

// Loop around all processors
TargetHandleList l_allProcChips;
getAllChips(l_allProcChips, TYPE_PROC, false);
for(auto l_chip : l_allProcChips)
{
// value for master set above
if( l_chip == l_pMasterProcChip )
{
continue;
}

//Turn the SBE Console enablement off for all slave chips
ATTR_LPC_CONSOLE_CNFG_type l_consoleOff = LPC_CONSOLE_CNFG_DISABLE;
l_chip->setAttr<ATTR_LPC_CONSOLE_CNFG>(l_consoleOff);
}


// Do some special memory-preserving work
if(i_isMpipl)
{
l_pTopLevel->setAttr<ATTR_IS_MPIPL_HB>(1);
Expand Down

0 comments on commit 459e8bf

Please sign in to comment.