Skip to content

Commit

Permalink
Zero out TPM FRU ID to avoid hostboot crash
Browse files Browse the repository at this point in the history
This change allows us to update the MRW with the TPM FRU ID while
ignoring its value in hostboot to avoid crashing. In a later commit
we will handle the FRU ID properly.

Change-Id: Iefef07f9db36f22581423e8a0cf61f1b0a034d1f
RTC:194318
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/68543
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
popfuture authored and dcrowell77 committed Nov 12, 2018
1 parent 2e77a7f commit 4694514
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/usr/ipmiext/ipmifruinv.C
Original file line number Diff line number Diff line change
Expand Up @@ -2306,6 +2306,16 @@ void IPMIFRUINV::gatherSetData(const TARGETING::Target* i_pSys,
TARGETING::TargetHandle_t pTarget = *pTarget_it;
uint32_t l_fruId = pTarget->getAttr<TARGETING::ATTR_FRU_ID>();

// Check if this is a tpm target, if so zero out the fru entry for now
// until we are ready to handle it. The reason we can't handle it is
// because it doesn't exist in the MRW yet. But if we add it, then
// then hostboot will crash. This helps escape the chicken/egg scenario.
// TODO RTC 194318 - remove later as a second step
if (TARGETING::TYPE_TPM == pTarget->getAttr<TARGETING::ATTR_TYPE>())
{
l_fruId = 0;
}

// check if this is a membuf target, if it is and the special
// attribute to say we want a separate fru entry for the centaur ecids
// is populated, then we will push that ecid to the potential frus
Expand Down

0 comments on commit 4694514

Please sign in to comment.