Skip to content

Commit

Permalink
PRD: Disable Dynamic Memory Deallocation for MBA
Browse files Browse the repository at this point in the history
Disabling the function until we are able to completely support it for the MBA.
This avoids sending any false messages to the hypervisor.

Change-Id: I4b694c13e09253b126e0faeb2a760bf673f212f7
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56259
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/56409
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
  • Loading branch information
zane131 committed Mar 29, 2018
1 parent a6bd3b6 commit 46cd995
Showing 1 changed file with 16 additions and 7 deletions.
23 changes: 16 additions & 7 deletions src/usr/diag/prdf/plat/mem/prdfMemDynDealloc.C
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,6 @@ int32_t __getMcaPortAddr( ExtensibleChip * i_chip, MemAddr i_addr,
template<TYPE T>
int32_t getSystemAddr( ExtensibleChip * i_chip, MemAddr i_addr,
uint64_t & o_addr );
template<>
int32_t getSystemAddr<TYPE_MBA>( ExtensibleChip * i_chip, MemAddr i_addr,
uint64_t & o_addr )
{
// TODO - RTC: 157588
return SUCCESS;
}

template<>
int32_t getSystemAddr<TYPE_MCA>( ExtensibleChip * i_chip, MemAddr i_addr,
Expand Down Expand Up @@ -371,6 +364,22 @@ int32_t getSystemAddr<TYPE_MCA>( ExtensibleChip * i_chip, MemAddr i_addr,
#undef PRDF_FUNC
}

template<>
int32_t getSystemAddr<TYPE_MBA>( ExtensibleChip * i_chip, MemAddr i_addr,
uint64_t & o_addr )
{
#define PRDF_FUNC "[MemDealloc::getSystemAddr] "

// TODO - RTC: 190115
PRDF_ERR( PRDF_FUNC "not supported on MBA yet: i_chip=0x%08x",
i_chip->getHuid() );
return FAIL; // Returning FAIL will prevent us from sending any false
// messages to the hypervisor.

#undef PRDF_FUNC
}

//------------------------------------------------------------------------------

template<TYPE T>
int32_t page( ExtensibleChip * i_chip, MemAddr i_addr )
Expand Down

0 comments on commit 46cd995

Please sign in to comment.