Skip to content

Commit

Permalink
Return only present DIMM children to fapi
Browse files Browse the repository at this point in the history
Switching from possible to present for fapi2::getChildren
when asked about DIMMs

Change-Id: If5febce96b546ad1553dad0f5feb37ca07c4da97
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/41274
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Reviewed-by: Thi N. Tran <thi@us.ibm.com>
Reviewed-by: JACOB L. HARVEY <jlharvey@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dcrowell77 committed Jun 7, 2017
1 parent 94eff06 commit 47f3435
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/include/usr/fapi2/target.H
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,7 @@ FAPI_DBG(ENTER_MRK "getChildren. Type 0x%08x State:0x%08x", T, i_state);

if(!l_functional)
{
// PERV targets use a special interface
if(K == fapi2::TARGET_TYPE_PERV)
{
TARGETING::getPervasiveChildTargetsByState(l_childList,
Expand All @@ -792,6 +793,18 @@ FAPI_DBG(ENTER_MRK "getChildren. Type 0x%08x State:0x%08x", T, i_state);
l_type,
TARGETING::UTIL_FILTER_ALL);
}
// DIMMs need to use PRESENT so that we don't report things
// that aren't installed
else if(K == fapi2::TARGET_TYPE_DIMM)
{
TARGETING::getChildAffinityTargetsByState(l_childList,
static_cast<TARGETING::Target*>(this->get()),
TARGETING::CLASS_NA,
l_type,
TARGETING::UTIL_FILTER_PRESENT);
}
// All chiplets need to use ALL so that we report the architectural
// limits, versus what PG might say
else
{
TARGETING::getChildAffinityTargetsByState(l_childList,
Expand Down

0 comments on commit 47f3435

Please sign in to comment.