Skip to content

Commit

Permalink
Disable HW439321 workaround in dd1.3
Browse files Browse the repository at this point in the history 
Change-Id: Iefeff37efedc89567c229c1780ce0054b8279b36
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63221
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Reviewed-by: SHELTON LEUNG <sleung@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Reviewed-by: DANIEL C. HOWE <dchowe@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63373
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
@adamant1 @crgeddes
adamant1 authored and crgeddes committed Aug 1, 2018
1 parent 85bd498 commit 4b51087
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 2 deletions.
16 changes: 14 additions & 2 deletions src/import/chips/p9/procedures/hwp/initfiles/p9c_dmi_scom.C
View file
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ constexpr uint64_t literal_12 = 12;
constexpr uint64_t literal_4 = 4;
constexpr uint64_t literal_0b0100 = 0b0100;
constexpr uint64_t literal_28 = 28;
constexpr uint64_t literal_0b01010 = 0b01010;
constexpr uint64_t literal_0 = 0;
constexpr uint64_t literal_0b01010 = 0b01010;
constexpr uint64_t literal_0b11111 = 0b11111;
constexpr uint64_t literal_8 = 8;
constexpr uint64_t literal_0x1 = 0x1;
constexpr uint64_t literal_0x3 = 0x3;
Expand Down Expand Up @@ -69,6 +70,9 @@ fapi2::ReturnCode p9c_dmi_scom(const fapi2::Target<fapi2::TARGET_TYPE_DMI>& TGT0
FAPI_TRY(FAPI_ATTR_GET_PRIVILEGED(fapi2::ATTR_EC, TGT3, l_chip_ec));
uint64_t l_def_ENABLE_AMO_CACHING = literal_1;
uint64_t l_def_ENABLE_AMO_CLEAN_LINES = literal_1;
fapi2::ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13_Type l_TGT3_ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13;
FAPI_TRY(FAPI_ATTR_GET(fapi2::ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13, TGT3,
l_TGT3_ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13));
uint64_t l_def_ENABLE_DYNAMIC_64_128B_READS = literal_0;
uint64_t l_def_ENABLE_PREFETCH_DROP_PROMOTE_BASIC = literal_1;
uint64_t l_def_ENABLE_RMW_IN_PROC = literal_1;
Expand Down Expand Up @@ -127,7 +131,15 @@ fapi2::ReturnCode p9c_dmi_scom(const fapi2::Target<fapi2::TARGET_TYPE_DMI>& TGT0
constexpr auto l_MC01_CHAN0_ATCL_CL_CLSCOM_MCPERF2_ENABLE_REFRESH_BLOCK_DISP_OFF = 0x0;
l_scom_buffer.insert<18, 1, 63, uint64_t>(l_MC01_CHAN0_ATCL_CL_CLSCOM_MCPERF2_ENABLE_REFRESH_BLOCK_DISP_OFF );
l_scom_buffer.insert<50, 5, 59, uint64_t>(literal_28 );
l_scom_buffer.insert<55, 5, 59, uint64_t>(literal_0b01010 );

if ((l_TGT3_ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13 == literal_0))
{
l_scom_buffer.insert<55, 5, 59, uint64_t>(literal_0b01010 );
}
else if ((l_TGT3_ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13 == literal_1))
{
l_scom_buffer.insert<55, 5, 59, uint64_t>(literal_0b11111 );
}

if ((l_def_ENABLE_DYNAMIC_64_128B_READS == literal_1))
{
Expand Down
17 changes: 17 additions & 0 deletions src/import/chips/p9/procedures/xml/attribute_info/chip_ec_attributes.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7724,4 +7724,21 @@
</chipEcFeature>
</attribute>
<!-- ******************************************************************** -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_HW439321_FIXED_IN_P9UDD13</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Disable RMW10 Hangbuster workaround in dd1.3 because of hardware fix
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_CUMULUS</name>
<ec>
<value>0x13</value>
<test>GREATER_THAN_OR_EQUAL</test>
</ec>
</chip>
</chipEcFeature>
</attribute>
<!-- ******************************************************************** -->
</attributes>

0 comments on commit 4b51087

Please sign in to comment.