Skip to content

Commit

Permalink
Remove Istep 10.3 From IPL Flow
Browse files Browse the repository at this point in the history
Istep 10.3 (host_set_voltages) has been moved to Istep 8.12
and needs to be no-oped. Executing host_set_voltages twice
causes crashes due to secureboot thinking we are trying to
skip an istep. Note that validateSecuritySettings that was
performed in 10.3 has now been moved to 10.4 (with the required
sub-routines).

Change-Id: I81284157dedebb3f4ee357ce28b29b1dd6a3fe8a
CQ:SW416209
CMVC-Coreq:1044932
Backport: release-fips910
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/53443
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Nicholas E. Bofferding <bofferdn@us.ibm.com>
Reviewed-by: Michael Baiocchi <mbaiocch@us.ibm.com>
Reviewed-by: Marshall J. Wilks <mjwilks@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Ilya Smirnov authored and dcrowell77 committed Feb 8, 2018
1 parent c9c74db commit 4bcfb10
Show file tree
Hide file tree
Showing 4 changed files with 737 additions and 894 deletions.
20 changes: 5 additions & 15 deletions src/include/usr/isteps/istep10list.H
Expand Up @@ -36,8 +36,8 @@
* : Integrate P9 Islands into SMP
* 10.02 host_slave_sbe_update
* : Update slave SBE
* 10.03 host_set_voltages
* : Set correct chip voltages
* 10.03 <empty>
* :
* 10.04 proc_cen_ref_clk_enable
* : Setup centaur ref clocks
* 10.05 proc_enable_osclite
Expand Down Expand Up @@ -93,16 +93,6 @@ void* call_proc_build_smp( void *io_pArgs );
*/
void* call_host_slave_sbe_update( void *io_pArgs );

/**
* @brief host_set_voltages
*
* param[in,out] - pointer to any arguments, usually NULL
*
* return any error logs to istep
*
*/
void* call_host_set_voltages( void *io_pArgs );

/**
* @brief proc_cen_ref_clk_enable
*
Expand Down Expand Up @@ -245,9 +235,9 @@ const TaskInfo g_istep10[] = {
{ START_FN, EXT_IMAGE, NORMAL_IPL_OP, true }
},
{
ISTEPNAME(10,03,"host_set_voltages"),
ISTEP_10::call_host_set_voltages,
{ START_FN, EXT_IMAGE, NORMAL_IPL_OP, false }
"", // empty istep
NULL,
{ NONE, EXT_IMAGE, IPL_NOOP, false }
},
{
ISTEPNAME(10,04,"proc_cen_ref_clk_enable"),
Expand Down

0 comments on commit 4bcfb10

Please sign in to comment.