Skip to content

Commit

Permalink
Increase default watchdog timeout to 10 minutes
Browse files Browse the repository at this point in the history
We have discovered some error cases within the memory diagnostics
step where a single hardware operation can take up to 6 minutes
to complete.  The code sends a watchdog ping before issuing any
command, but the current timeout (2 minutes) is insufficient to
handle these long commands.

Resolves boston-openpower/#1240

Change-Id: I4e27a45c927c014b5fcc28d4510c5996a7009953
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/59254
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dcrowell77 committed May 29, 2018
1 parent a093275 commit 4bfa55d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/include/usr/ipmi/ipmiwatchdog.H
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ namespace IPMIWATCHDOG
// Globals/Constants
/******************************************************************************/
/**
* @brief the default watchdog countdown setting it to 120 seconds.
* @brief the default watchdog countdown setting it to 600 seconds.
*
*/
// The config option CONFIG_BMC_IPMI_LONG_WATCHDOG allows a tester to use a
Expand All @@ -53,7 +53,7 @@ namespace IPMIWATCHDOG
#ifdef CONFIG_BMC_IPMI_LONG_WATCHDOG
const uint16_t DEFAULT_WATCHDOG_COUNTDOWN = 3600; //60 minutes
#else
const uint16_t DEFAULT_WATCHDOG_COUNTDOWN = 120; //2 minutes
const uint16_t DEFAULT_WATCHDOG_COUNTDOWN = 600; //10 minutes
#endif

/**
Expand Down

0 comments on commit 4bfa55d

Please sign in to comment.