Skip to content

Commit

Permalink
Moves sync code to generic folder
Browse files Browse the repository at this point in the history
Change-Id: I440cdb0ea105a6dbdcd0ac26696308e55d56f88b
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/65786
Dev-Ready: STEPHEN GLANCY <sglancy@us.ibm.com>
Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: ANDRE A. MARIN <aamarin@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/66323
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
  • Loading branch information
sglancy6 authored and crgeddes committed Sep 19, 2018
1 parent 8247477 commit 4f8cfb6
Show file tree
Hide file tree
Showing 19 changed files with 2,110 additions and 1,617 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,35 +61,5 @@ fapi_try_exit:
return fapi2::current_err;
}

///
/// @brief Sets pre_eff_config attributes
/// @param[in] i_target the DIMM target
/// @param[in] i_spd_decoder SPD decoder
/// @return FAPI2_RC_SUCCESS iff ok
///
fapi2::ReturnCode set_pre_init_attrs( const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target,
const spd::facade& i_spd_decoder )
{
fapi2::ReturnCode l_rc(fapi2::FAPI2_RC_SUCCESS);
mss::pre_data_engine<mss::NIMBUS> l_data_engine(i_target, i_spd_decoder, l_rc);
FAPI_TRY(l_rc, "Failed to instantiate pre_data_engine object for %s", spd::c_str(i_target));

// Set attributes needed before eff_config
// DIMM type and DRAM gen are needed for c_str to aid debugging
FAPI_TRY(l_data_engine.set_dimm_type(), "Failed to set DIMM type %s", spd::c_str(i_target) );
FAPI_TRY(l_data_engine.set_dram_gen(), "Failed to set DRAM gen %s", spd::c_str(i_target) );

// Hybrid and hybrid media help detect hybrid modules, specifically NVDIMMs for Nimbus
FAPI_TRY(l_data_engine.set_hybrid(), "Failed to set Hybrid %s", spd::c_str(i_target) );
FAPI_TRY(l_data_engine.set_hybrid_media(), "Failed to set Hybrid Media %s", spd::c_str(i_target) );

// Number of master ranks needed for VPD decoding
// and dimm_ranks_configured is a PRD attr...
FAPI_TRY(l_data_engine.set_master_ranks(), "Failed to set Master ranks %s", spd::c_str(i_target) );
FAPI_TRY(l_data_engine.set_dimm_ranks_configured(), "Failed to set DIMM ranks configured %s", spd::c_str(i_target) );

fapi_try_exit:
return fapi2::current_err;
}

} // mss
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#define _MSS_ATTR_SETTERS_H_

#include <fapi2.H>
#include <generic/memory/lib/spd/spd_facade.H>

namespace mss
{
Expand All @@ -53,15 +52,6 @@ namespace mss
fapi2::ReturnCode set_voltage_attributes(const fapi2::Target<fapi2::TARGET_TYPE_MCS>& i_target_mcs,
uint32_t i_selected_dram_voltage,
uint32_t i_selected_dram_voltage_vpp);

///
/// @brief Sets pre_eff_config attributes
/// @param[in] i_target the DIMM target
/// @param[in] i_spd_decoder SPD decoder
/// @return FAPI2_RC_SUCCESS iff ok
///
fapi2::ReturnCode set_pre_init_attrs( const fapi2::Target<fapi2::TARGET_TYPE_DIMM>& i_target,
const spd::facade& i_spd_decoder );
} // mss

#endif
Expand Down

0 comments on commit 4f8cfb6

Please sign in to comment.