Skip to content

Commit

Permalink
PM: Move to chip EC based #V validity checking in p9_pstate_parameter…
Browse files Browse the repository at this point in the history
…_block

- Was always returning SUCCESS which caused p9_hcode_image_build to not
  properly terminate (false error logs)
- Added EC feature attribute to skip #V validity checking and thus disabling
  pstates for Nimbus < 20 and Cumulus < 11
- Initalized wof io_size to 0.
- Rebased
- Added override attribute ATTR_SYSTEM_POUNDV_VALIDITY_HALT_DISABLE to disable
  killing the IPL upon #V validity check failure.  Disables Pstates and
  continues.  This allow the use of parts that don't have good #V for other,
  non-Pstate oriented purposes.  Marked with new <overrideOnly/> tag.

Change-Id: I3fdc8a02f16d6779723461342e4d2449989cb65a
Original-Change-Id: Ia238af9758ae1fe35d39fa536d73ec41e85f9498
CQ: SW400102
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/45185
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: PPE CI <ppe-ci+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <prasadbgr@in.ibm.com>
Reviewed-by: Juan R. Medina <jrmedina@us.ibm.com>
Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/55572
CI-Ready: Daniel M. Crowell <dcrowell@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
stillgs authored and dcrowell77 committed Mar 13, 2018
1 parent 14f465d commit 52074db
Showing 1 changed file with 25 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5002,6 +5002,31 @@
</chip>
</chipEcFeature>
</attribute>
<!-- ********************************************************************* -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_POUNDV_VALIDATE_DISABLE</id>
<targetType>TARGET_TYPE_PROC_CHIP</targetType>
<description>
Disables the checking of #V validity by p9_pstate_parameter_block.
If not disable, invalid #V will fail to IPL.
</description>
<chipEcFeature>
<chip>
<name>ENUM_ATTR_NAME_NIMBUS</name>
<ec>
<value>0x20</value>
<test>LESS_THAN</test>
</ec>
</chip>
<chip>
<name>ENUM_ATTR_NAME_CUMULUS</name>
<ec>
<value>0x11</value>
<test>LESS_THAN</test>
</ec>
</chip>
</chipEcFeature>
</attribute>
<!-- ********************************************************************* -->
<attribute>
<id>ATTR_CHIP_EC_FEATURE_OBUS_HW419305</id>
Expand Down

0 comments on commit 52074db

Please sign in to comment.