Skip to content

Commit

Permalink
Stop mcbist during nvdimm restore to prevent broadcast out of sync
Browse files Browse the repository at this point in the history
If mcbist is running during nvdimm restore it could detect UE due
to the drams not in the right state and could lead to broadcast out
of sycn error

Change-Id: I1dbf79fb4b3c66f2100eb3dbe202cfae22d35677
CQ:SW470102
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80645
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: STEPHEN GLANCY <sglancy@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/80666
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Tsung Yeung authored and dcrowell77 committed Jul 22, 2019
1 parent 3a513ca commit 533e200
Showing 1 changed file with 4 additions and 0 deletions.
Expand Up @@ -266,10 +266,14 @@ template<>
fapi2::ReturnCode self_refresh_entry( const fapi2::Target<fapi2::TARGET_TYPE_MCA>& i_target )
{
fapi2::buffer<uint64_t> l_mbarpc0_data, l_mbastr0_data;
const auto& l_mcbist = mss::find_target<fapi2::TARGET_TYPE_MCBIST>(i_target);

// Entry time to 0 for immediate entry
constexpr uint64_t l_str_entry_time = 0;

// Stop mcbist (scrub) in case of MPIPL. It will get restarted in the later istep
FAPI_TRY(mss::mcbist::start_stop(l_mcbist, mss::states::STOP));

// Step 1 - In MBARPC0Q, disable power domain control, set domain to MAXALL_MIN0,
// and disable minimum domain reduction (allow immediate entry of STR)
FAPI_TRY(mss::mc::read_mbarpc0(i_target, l_mbarpc0_data));
Expand Down

0 comments on commit 533e200

Please sign in to comment.