Skip to content

Commit

Permalink
Fix symsmode check to allow in-memory lookup
Browse files Browse the repository at this point in the history
Switched the default value from empty string to 'default' and
fix the associated checks.

Change-Id: If8379ad02854fd46b800e5dbfdfef41558ee745e
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/63154
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: William G. Hoffa <wghoffa@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R. Geddes <crgeddes@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dcrowell77 committed Jul 24, 2018
1 parent 331b4bf commit 53d16c2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/build/debug/Hostboot/_DebugFramework.pm
Original file line number Diff line number Diff line change
Expand Up @@ -502,12 +502,13 @@ sub findPointer
my $size;

my $symsmode = ::getSymsMode();
if( ($symsmode =~ "") || ($symsmode =~ "usemem") )

if( ($symsmode =~ "default") || ($symsmode =~ "usemem") )
{
($addr, $size ) = findDebugPointer( $dbgptrstr );
}

if( (($symsmode =~ "") && (not defined $addr))
if( (($symsmode =~ "default") && (not defined $addr))
|| ($symsmode =~ "usefile") )
{
#::userDisplay( "*Using Symbol File*\n" );
Expand Down
2 changes: 1 addition & 1 deletion src/build/debug/ecmd-debug-framework.pl
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
# "" : Default - Try to use memory, fall-back to symbol files
# "usefile" : Only use the symbol files
# "usemem" : Only use the data from memory
my $useSymsMode = "";
my $useSymsMode = "default";

GetOptions("tool:s" => \$tool,
"tool-options:s" => \$toolOptions,
Expand Down

0 comments on commit 53d16c2

Please sign in to comment.