Skip to content

Commit

Permalink
Add recovery summary traces for sbeAttemptRecovery for FSP runtime
Browse files Browse the repository at this point in the history
Previously you had to look at other traces, or decipher to binary
trace to determine if the sbe was recovered or not, this commit
adds clear traces after the recover effort is done to tell whether
it was successful or not.

Change-Id: I17ce4de2f7e1168409758ca0ef1a5eaa044d6728
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57466
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Jun 2, 2018
1 parent 384e76d commit 5684c60
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/usr/sbeio/common/sbe_attn.C
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ namespace SBEIO
// success or not
if (!l_sbeObj.isSbeAtRuntime())
{
TRACFCOMP( g_trac_sbeio,
"handleVitalAttn: SBE recovery attempt FAILED" );
/*@
* @errortype ERRL_SEV_PREDICTIVE
* @moduleid SBEIO_HANDLE_VITAL_ATTN
Expand Down Expand Up @@ -110,6 +112,8 @@ namespace SBEIO
// Inform OPAL the state of the SBE after a retry is successful
else
{
TRACFCOMP( g_trac_sbeio,
"handleVitalAttn: SBE recovery attempt was a SUCCESS" );
if (TARGETING::is_sapphire_load())
{
l_err = RT_SBEIO::vital_attn_inform_opal(i_procTarg,
Expand Down
2 changes: 2 additions & 0 deletions src/usr/util/runtime/rt_fwnotify.C
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,13 @@ void sbeAttemptRecovery(uint64_t i_data)
// Set msgType based on recovery success or failure (If sbe made it back to runtime)
if (l_SBEobj.isSbeAtRuntime())
{
TRACFCOMP(g_trac_runtime, "sbeAttemptRecovery: RECOVERY_SUCCESS");
l_req_fw_msg.generic_msg.msgType =
GenericFspMboxMessage_t::MSG_SBE_RECOVERY_SUCCESS;
}
else
{
TRACFCOMP(g_trac_runtime, "sbeAttemptRecovery: RECOVERY_FAILED");
l_req_fw_msg.generic_msg.msgType =
GenericFspMboxMessage_t::MSG_SBE_RECOVERY_FAILED;
}
Expand Down

0 comments on commit 5684c60

Please sign in to comment.