PRD: updates to TP_LFIR[21]

Change-Id: I93664273d914b0d325709339918c23e749d44e18
RTC: 169104
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36378
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/36517
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>

src/usr/diag/prdf/common/plat/p9/p9_nimbus.rule

@@ -2126,7 +2126,7 @@ group gTP_LFIR filter singlebit, cs_root_cause
     /** TP_LFIR[21]
      *  local errors from PORT2 ( error)
      */
-    (rTP_LFIR, bit(21)) ? PcbSlaveInternalParity;
+    (rTP_LFIR, bit(21)) ? pcb_slave_internal_parity;
 
     /** TP_LFIR[22]
      *  FIR error from SBE

src/usr/diag/prdf/common/plat/p9/p9_nimbus_actions.rule

@@ -41,7 +41,7 @@ actionclass thresholdPll
 # callout/gard the chip at threshold along with PLL scom
 # data captured.
 /** PCB Slave Internal parity error action */
-actionclass PcbSlaveInternalParity
+actionclass pcb_slave_internal_parity
 {
     capture(PllFIRs);
     calloutSelfHigh;

src/usr/diag/prdf/common/plat/p9/prdfP9Pll.C

@@ -383,30 +383,22 @@ PRDF_PLUGIN_DEFINE_NS( p9_nimbus, Proc, CheckErrorType );
  * @param i_chip P9 chip
  * @returns Failure or Success
  */
-int32_t clearParityError( ExtensibleChip * i_chip)
+int32_t clearParityError( ExtensibleChip * i_chip,
+                          STEP_CODE_DATA_STRUCT & i_sc )
 {
     #define PRDF_FUNC "[Proc::clearParityError] "
     int32_t rc = SUCCESS;
 
-    // Clear Chiplet parity error bits
-    ClearChipletParityError(i_chip, TYPE_PROC);
-    ClearChipletParityError(i_chip, TYPE_XBUS);
-    ClearChipletParityError(i_chip, TYPE_OBUS);
-    ClearChipletParityError(i_chip, TYPE_MCA);
-    ClearChipletParityError(i_chip, TYPE_PEC);
-    ClearChipletParityError(i_chip, TYPE_EQ);
-    ClearChipletParityError(i_chip, TYPE_CORE);
-
-    // Clear TPLFIR[21]
-    SCAN_COMM_REGISTER_CLASS * TP_LFIR_and =
-               i_chip->getRegister("TP_LFIR_AND");
-    TP_LFIR_and->setAllBits();
-    TP_LFIR_and->ClearBit(PLL_UNLOCK);
-    rc = TP_LFIR_and->Write();
-    if (rc != SUCCESS)
+    if ( CHECK_STOP != i_sc.service_data->getPrimaryAttnType() )
     {
-        PRDF_ERR(PRDF_FUNC "TP_LFIR_AND write failed"
-                 "for 0x%08x", i_chip->GetId());
+        // Clear Chiplet parity error bits
+        ClearChipletParityError(i_chip, TYPE_PROC);
+        ClearChipletParityError(i_chip, TYPE_XBUS);
+        ClearChipletParityError(i_chip, TYPE_OBUS);
+        ClearChipletParityError(i_chip, TYPE_MCA);
+        ClearChipletParityError(i_chip, TYPE_PEC);
+        ClearChipletParityError(i_chip, TYPE_EQ);
+        ClearChipletParityError(i_chip, TYPE_CORE);
     }
 
     return rc;