Skip to content

Commit

Permalink
Add hwp retry loop as workaround until we resolve timeout issue
Browse files Browse the repository at this point in the history
We were seeing check_for_ready timeout intermittently in driver
tests. In locally built driver we saw that if we retried the hwp
a few times we eventually passed. Incrementing the timeout value
in the HWP itself did not seem to make the problem go away. We will
remove this retry loop when we figure out the root of the problem.

Change-Id: If39965268349891fc9170a5a29193aaf6fb8d583
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/89780
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Yun Pan <yun.pan@ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Jan 21, 2020
1 parent 3346170 commit 5820710
Showing 1 changed file with 20 additions and 4 deletions.
24 changes: 20 additions & 4 deletions src/usr/isteps/istep10/call_proc_cen_ref_clk_enable.C
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2019 */
/* Contributors Listed Below - COPYRIGHT 2015,2020 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -1063,9 +1063,25 @@ void* call_proc_cen_ref_clk_enable(void *io_pArgs )
"for 0x%.08X", TARGETING::get_huid(l_ocmb));

fapi2::Target <fapi2::TARGET_TYPE_OCMB_CHIP> l_fapi_ocmb_target(l_ocmb);
FAPI_INVOKE_HWP(l_errl,
exp_check_for_ready,
l_fapi_ocmb_target);

// TODO CQ:SW482291 Remove this retry workaround when ocmb check_for_ready timeout issue is resolved
for(uint8_t i = 0; i < 10; i++)
{
FAPI_INVOKE_HWP(l_errl,
exp_check_for_ready,
l_fapi_ocmb_target);

// Preserve the error log if this is the last loop.
if(l_errl == NULL || i == 9)
{
break;
}
else
{
delete l_errl;
l_errl = NULL;
}
}

if (l_errl)
{
Expand Down

0 comments on commit 5820710

Please sign in to comment.