PRD: All TPS bans on MCA target should cause fetch CE masking

Currently, fetch CEs on MCA are only masked if TPS is banned using the TpsEvent contructor. Unfortunately, there are several other locations where TPS can be banned. So moved the support to MemTdCtlr::banTps(). Change-Id: I48791288bbfdd2299e10ef6382f4d926b67300ad CQ: SW433793 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/60969 Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com> Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com> Reviewed-by: Caleb N. Palmer <cnpalmer@us.ibm.com> Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61034 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
open-power · Jun 22, 2018 · 5a3703d · 5a3703d
1 parent 84a0b8e
commit 5a3703d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/usr/diag/prdf/common/plat/mem/prdfMemDbUtils.H b/src/usr/diag/prdf/common/plat/mem/prdfMemDbUtils.H
@@ -229,7 +229,10 @@ template<> inline
 void banTps<TARGETING::TYPE_MCA>( ExtensibleChip * i_chip,
                                   const MemRank & i_rank )
 {
+    // Ban TPS on this rank.
     getMcaDataBundle(i_chip)->getTdCtlr()->banTps( i_chip, i_rank );
+    // Permanently mask mainline NCEs and TCEs because of the TPS ban.
+    getMcaDataBundle(i_chip)->iv_maskMainlineNceTce = true;
 }
 
 template<> inline

diff --git a/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.H b/src/usr/diag/prdf/plat/mem/prdfMemTdCtlr.H
@@ -122,6 +122,7 @@ class MemTdCtlr
     /**
      * @brief  Bans TPS on the given rank. Any attempts to add a TPS procedure
      *         to the queue for this rank will be ignored.
+     * @param  i_chip MCA or MBA chip.
      * @param  i_rank The target slave rank.
      */
     void banTps( ExtensibleChip * i_chip, const MemRank & i_rank )

diff --git a/src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C b/src/usr/diag/prdf/plat/mem/prdfMemTps_rt.C
@@ -1151,9 +1151,6 @@ uint32_t TpsEvent<TYPE_MCA>::analyzePhase( STEP_CODE_DATA_STRUCT & io_sc,
         {
             // Ban TPS on this rank.
             MemDbUtils::banTps<TYPE_MCA>( iv_chip, iv_rank );
-
-            // Permanently mask mainline NCEs and TCEs.
-            getMcaDataBundle(iv_chip)->iv_maskMainlineNceTce = true;
         }
     }