Skip to content

Commit

Permalink
Fix EEPROM_VPD_PRIMARY_INFO attribute on proc targ in axone sim XML
Browse files Browse the repository at this point in the history
Up until this point in P9 systems this attribute has had the
maxMemorySizeKB = 0x80 (128 KB) and the chipCount = 0x02. While
this is partially true, hostboot should never access the 2nd 64 KB
chip. The MVPD is completely stored in the first 64 KB chip. This
commit intentionally does not fix previous system XMLs but it might
be worth investigating. MRW is still supplying the old 0x80, 0x02 values
for Nimbus/Cumuls system so it was decided to leave old values in our
sim xmls for those systems.

RTC: 196805
Change-Id: Ibec7412359b6cda24a255ec612a5774a7ed3ac30
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70259
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: Roland Veloz <rveloz@us.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
crgeddes authored and dcrowell77 committed Jan 14, 2019
1 parent ac15fd7 commit 5ccb0c4
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions src/usr/targeting/common/xmltohb/simics_AXONE.system.xml
Original file line number Diff line number Diff line change
Expand Up @@ -445,11 +445,13 @@
<id>EEPROM_VPD_BACKUP_INFO</id>
<default>
<field><id>byteAddrOffset</id><value>0x02</value></field>
<field><id>chipCount</id><value>0x02</value></field>
<field><id>devAddr</id><value>0xA0</value></field>
<field><id>engine</id><value>1</value></field>
<field><id>i2cMasterPath</id><value>physical:sys-0/node-0/proc-0</value></field>
<field><id>maxMemorySizeKB</id><value>0x80</value></field>
<!-- Note: that there is actually two 64KB chips associated with the MVPD SEEPROM
but Hostboot should never access the second chip -->
<field><id>chipCount</id><value>0x01</value></field>
<field><id>maxMemorySizeKB</id><value>0x40</value></field>
<field><id>port</id><value>2</value></field>
<field><id>writeCycleTime</id><value>0x0A</value></field>
<field><id>writePageSize</id><value>0x80</value></field>
Expand All @@ -459,11 +461,13 @@
<id>EEPROM_VPD_PRIMARY_INFO</id>
<default>
<field><id>byteAddrOffset</id><value>0x02</value></field>
<field><id>chipCount</id><value>0x02</value></field>
<field><id>devAddr</id><value>0xA0</value></field>
<field><id>engine</id><value>1</value></field>
<field><id>i2cMasterPath</id><value>physical:sys-0/node-0/proc-0</value></field>
<field><id>maxMemorySizeKB</id><value>0x80</value></field>
<!-- Note: that there is actually two 64KB chips associated with the MVPD SEEPROM
but Hostboot should never access the second chip -->
<field><id>chipCount</id><value>0x01</value></field>
<field><id>maxMemorySizeKB</id><value>0x40</value></field>
<field><id>port</id><value>0</value></field>
<field><id>writeCycleTime</id><value>0x0A</value></field>
<field><id>writePageSize</id><value>0x80</value></field>
Expand Down

0 comments on commit 5ccb0c4

Please sign in to comment.