Skip to content

Commit

Permalink
PRD: Runtime TPS Design Fixes
Browse files Browse the repository at this point in the history
Change-Id: I78675ac1b1f2fc5c3e331123d3e46bda2c2e643c
CQ: SW403636
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/46979
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamin J. Weisenbeck <bweisenb@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/48074
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
  • Loading branch information
cnpalmer authored and zane131 committed Oct 9, 2017
1 parent 782095a commit 5e97dc7
Show file tree
Hide file tree
Showing 2 changed files with 122 additions and 107 deletions.
40 changes: 19 additions & 21 deletions src/usr/diag/prdf/plat/mem/prdfMemTps.H
Expand Up @@ -99,37 +99,35 @@ class TpsEvent : public TdEntry

/**
* @brief Analyzes the counts that summarize the symbol CE counts.
* @param i_badDqCount Number of nibbles with a bad DQ
* @param i_badChipCount Number of nibbles with a bad Chip
* @param i_nonZeroSumCount Number of nibbles under threshold with a
* non-zero sum
* @param i_singleSymCount Number of nibbles under threshold with a
* single symbol count greater than one
* @param i_symList Vector of all symbols with counts > 0.
* @param i_badDqCount Number of nibbles with a bad DQ
* @param i_badChipCount Number of nibbles with a bad Chip
* @param i_sumAboveOneCount Number of nibbles under threshold with a
* sum greater than 1
* @param i_singleSymCount Number of nibbles under threshold with only
* a single symbol with a non-zero count, and
* that count is > 1
* @param io_sc The step code data struct.
* @return Non-SUCCESS if an internal function fails, SUCCESS otherwise.
*/
uint32_t analyzeCeSymbolCounts( CeCount i_badDqCount,
CeCount i_badChipCount, CeCount i_nonZeroSumCount,
CeCount i_singleSymCount, MemUtils::MaintSymbols i_symList,
STEP_CODE_DATA_STRUCT & io_sc );
CeCount i_badChipCount, CeCount i_sumAboveOneCount,
CeCount i_singleSymCount, STEP_CODE_DATA_STRUCT & io_sc );

/**
* @brief Gets the counts that summarize the symbol CE counts.
* @param io_badDqCount Number of nibbles with a bad DQ
* @param io_badChipCount Number of nibbles with a bad Chip
* @param io_nonZeroSumCount Number of nibbles under threshold with a
* non-zero sum
* @param io_singleSymCount Number of nibbles under threshold with a
* single symbol count greater than one
* @param o_symList Vector of all symbols with CE counts > 0.
* @param io_sc The step code data struct.
* @param io_badDqCount Number of nibbles with a bad DQ
* @param io_badChipCount Number of nibbles with a bad Chip
* @param io_sumAboveOneCount Number of nibbles under threshold with a
* sum greater than 1
* @param io_singleSymCount Number of nibbles under threshold with only
* a single symbol with a non-zero count, and
* that count is > 1
* @param io_sc The step code data struct.
* @return Non-SUCCESS if an internal function fails, SUCCESS otherwise.
*/
uint32_t getSymbolCeCounts( CeCount & io_badDqCount,
CeCount & io_badChipCount, CeCount & io_nonZeroSumCount,
CeCount & io_singleSymCount, MemUtils::MaintSymbols & o_symList,
STEP_CODE_DATA_STRUCT & io_sc );
CeCount & io_badChipCount, CeCount & io_sumAboveOneCount,
CeCount & io_singleSymCount, STEP_CODE_DATA_STRUCT & io_sc );

/**
* @brief Does isolation for CE attentions.
Expand Down

0 comments on commit 5e97dc7

Please sign in to comment.