Skip to content

Commit

Permalink
Fixed firmware calls to background scrub
Browse files Browse the repository at this point in the history
Change-Id: I3147a1460bec748b822e1c2fa2f23f08a244c6b6
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/96127
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/96157
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
  • Loading branch information
Matthickman14 authored and crgeddes committed May 20, 2020
1 parent f5653b1 commit 5ef6613
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 1 deletion.
Expand Up @@ -99,7 +99,10 @@ fapi2::ReturnCode exp_background_scrub( const fapi2::Target<fapi2::TARGET_TYPE_O
const mss::mcbist::speed i_speed,
const mss::mcbist::address& i_address )
{
return mss::memdiags::background_scrub<mss::mc_type::EXPLORER>(i_target, i_stop, i_speed, i_address);
return mss::memdiags::mss_firmware_background_scrub_helper<mss::mc_type::EXPLORER>(i_target,
i_stop,
i_speed,
i_address);
}

///
Expand Down
33 changes: 33 additions & 0 deletions src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H
Expand Up @@ -1303,6 +1303,39 @@ fapi_try_exit:
return fapi2::current_err;
}

///
/// @brief Begin firmware background scrub helper
/// @tparam MC the mc type of the T
/// @tparam T fapi2::TargetType of the MCBIST engine
/// @tparam TT the mcbistTraits associated with T
/// @param[in] i_target MC
/// @param[in] i_stop stop conditions
/// @param[in] i_speed the speed to scrub
/// @param[in] i_address mcbist::address representing the address from which to start
/// @return FAPI2_RC_SUCCESS iff ok
///
template< mss::mc_type MC = DEFAULT_MC_TYPE, fapi2::TargetType T, typename TT = mcbistTraits<MC, T> >
fapi2::ReturnCode mss_firmware_background_scrub_helper( const fapi2::Target<T>& i_target,
const stop_conditions<MC>& i_stop,
const speed i_speed,
const mss::mcbist::address& i_address )
{
FAPI_INF("Start mss_firmware_background_scrub_helper on: %s", mss::c_str( i_target ));

// Start background scrub
FAPI_TRY ( mss::memdiags::background_scrub<MC>( i_target,
i_stop,
i_speed,
i_address) );

// Unmask firs after background scrub is started
FAPI_TRY ( mss::unmask::after_background_scrub<MC>( i_target ) );

fapi_try_exit:
return fapi2::current_err;
}


} // namespace memdiags

} // namespace mss
Expand Down

0 comments on commit 5ef6613

Please sign in to comment.