Skip to content

Commit

Permalink
Update the no sync attributes xml.
Browse files Browse the repository at this point in the history
Update the no sync attribute xml with a new tag indicating
whether the compile time check for usage on fsp should be
skipped.

Change-Id: I9532485b41b89a437914aade312d598a5e4a52b1
CMVC-Prereq: 1060012
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/61454
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com>
Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
  • Loading branch information
dhruvibm authored and dcrowell77 committed Jun 30, 2018
1 parent e867278 commit 62011de
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions src/usr/targeting/common/xmltohb/xmltohb.pl
Original file line number Diff line number Diff line change
Expand Up @@ -204,11 +204,19 @@
}

my @nonSyncAttributes = {};
my @fspAccesCheck = {};
if ($nonSyncAttribFile ne "")
{
my $nsa = $xml->XMLin($nonSyncAttribFile,
KeyAttr => 'id', ForceArray=>1);
@nonSyncAttributes = values %$nsa;
my $nsa = $xml->XMLin($nonSyncAttribFile, ForceArray=>['attribute']);
foreach my $attr (@{$nsa->{attribute}})
{
my $attrName = $attr->{id};
if (!defined($attr->{fspaccess_nosync}))
{
push(@fspAccesCheck, $attrName);
}
push(@nonSyncAttributes, $attrName);
}
}

# save attributes defined as Target_t type
Expand Down Expand Up @@ -2501,7 +2509,7 @@ sub writeTraitFileTraits {
$traits .= " notFspMutex,";
}

if (!($attribute->{id} ~~ @nonSyncAttributes))
if (!($attribute->{id} ~~ @fspAccesCheck))
{
$traits .= " fspAccessible,";
}
Expand Down

0 comments on commit 62011de

Please sign in to comment.