Skip to content

Commit

Permalink
xstop_analysis: change the order of addr/val in pnor data structure
Browse files Browse the repository at this point in the history
GPEs require things to be on 8-byte boundary for uint64_t and 4-byte
for uint32_t. So, swapping the order helps align things.

Change-Id: I9de2660d46314583ab34cab9343239dbbfd21c8f
Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/43402
Reviewed-by: ILYA SMIRNOV <ismirno@us.ibm.com>
Reviewed-by: Brian J. Stegmiller <bjs@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Zane C. Shelley <zshelle@us.ibm.com>
  • Loading branch information
Prachi Gupta authored and zane131 committed Jul 22, 2017
1 parent c964a86 commit 708a0da
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/usr/diag/prdf/occ_firdata/pnorData_common.h
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ static inline PNOR_Trgt_t PNOR_getTrgt( uint32_t i_trgtType, uint32_t i_chipPos,

/** Information for a normal register. */
/* NOTE: This structure is 4-byte word aligned. */
//The order matters here due to hardware limitations on the GPE
typedef struct __attribute__((packed))
{
uint32_t addr; /** 32-bit address */
uint64_t val; /** 64-bit value */
uint32_t addr; /** 32-bit address */

} PNOR_Reg_t;

Expand Down

0 comments on commit 708a0da

Please sign in to comment.