Skip to content

Commit

Permalink
PRD: NVDIMM only update status bits for predictive logs
Browse files Browse the repository at this point in the history
Change-Id: I55251bdf32a32ecccebe1645067668ea3328cec9
CQ: SW482090
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88167
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Benjamen G Tyner <ben.tyner@ibm.com>
Reviewed-by: Brian J Stegmiller <bjs@us.ibm.com>
Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/88470
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
  • Loading branch information
cnpalmer authored and zane131 committed Dec 13, 2019
1 parent 5eaa67a commit 70ef787
Showing 1 changed file with 21 additions and 14 deletions.
Expand Up @@ -199,14 +199,17 @@ void ServiceDataCollector::clearNvdimmMruListGard()
if ( TYPE_DIMM == PlatServices::getTargetType(trgt) &&
isNVDIMM(trgt) )
{
// Send the message to PHYP/Hostboot
uint32_t l_rc = PlatServices::nvdimmNotifyProtChange( trgt,
NVDIMM::NVDIMM_RISKY_HW_ERROR );
if ( SUCCESS != l_rc )
// Send the message to PHYP/Hostboot if a predictive log
if ( queryServiceCall() )
{
PRDF_TRAC( PRDF_FUNC "nvdimmNotifyProtChange(0x%08x) "
"failed.", PlatServices::getHuid(trgt) );
continue;
uint32_t l_rc = PlatServices::nvdimmNotifyProtChange( trgt,
NVDIMM::NVDIMM_RISKY_HW_ERROR );
if ( SUCCESS != l_rc )
{
PRDF_TRAC( PRDF_FUNC "nvdimmNotifyProtChange(0x%08x) "
"failed.", PlatServices::getHuid(trgt) );
continue;
}
}
#ifndef __HOSTBOOT_RUNTIME
// IPL, clear Gard
Expand All @@ -227,14 +230,18 @@ void ServiceDataCollector::clearNvdimmMruListGard()
if ( TYPE_DIMM == PlatServices::getTargetType(dimm) &&
isNVDIMM(dimm) )
{
// Send the message to PHYP/Hostboot
uint32_t l_rc = PlatServices::nvdimmNotifyProtChange( dimm,
NVDIMM::NVDIMM_RISKY_HW_ERROR );
if ( SUCCESS != l_rc )
// Send the message to PHYP/Hostboot if a predictive log
if ( queryServiceCall() )
{
PRDF_TRAC( PRDF_FUNC "nvdimmNotifyProtChange(0x%08x) "
"failed.", PlatServices::getHuid(dimm) );
continue;
uint32_t l_rc = PlatServices::nvdimmNotifyProtChange(
dimm, NVDIMM::NVDIMM_RISKY_HW_ERROR );
if ( SUCCESS != l_rc )
{
PRDF_TRAC( PRDF_FUNC "nvdimmNotifyProtChange"
"(0x%08x) failed.",
PlatServices::getHuid(dimm) );
continue;
}
}
#ifndef __HOSTBOOT_RUNTIME
// IPL, clear Gard
Expand Down

0 comments on commit 70ef787

Please sign in to comment.