Skip to content

Commit

Permalink
Switch DECONFIG over to DELAYED_DECONFIG
Browse files Browse the repository at this point in the history
There is a race condition with the HWSV code on the FSP related
to how deconfigurations are happened.  A full solution on the FSP
side would be difficult so we're making a few targeted fixes on
the Hostboot side instead.

Change-Id: I57a6ec80df77464131020499e43181c1869d2514
CQ: SW481625
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/87928
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Christian R Geddes <crgeddes@us.ibm.com>
Reviewed-by: Matt Derksen <mderkse1@us.ibm.com>
Reviewed-by: William G Hoffa <wghoffa@us.ibm.com>
  • Loading branch information
dcrowell77 authored and wghoffa committed Dec 17, 2019
1 parent 0921b80 commit 75c0908
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions src/usr/isteps/istep06/call_host_voltage_config.C
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2016,2018 */
/* Contributors Listed Below - COPYRIGHT 2016,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -489,7 +489,7 @@ void* call_host_voltage_config( void *io_pArgs )

l_err->addHwCallout(l_proc,
HWAS::SRCI_PRIORITY_HIGH,
HWAS::DECONFIG,
HWAS::DELAYED_DECONFIG,
HWAS::GARD_NULL );

// Create IStep error log and
Expand Down Expand Up @@ -538,7 +538,7 @@ void* call_host_voltage_config( void *io_pArgs )

l_err->addHwCallout(l_proc,
HWAS::SRCI_PRIORITY_HIGH,
HWAS::DECONFIG,
HWAS::DELAYED_DECONFIG,
HWAS::GARD_NULL );

// Create IStep error log and
Expand Down
2 changes: 1 addition & 1 deletion src/usr/isteps/istep10/call_host_rng_bist.C
Expand Up @@ -120,7 +120,7 @@ void* call_host_rng_bist( void *io_pArgs )
{
l_err->addHwCallout( l_nxTarget,
HWAS::SRCI_PRIORITY_HIGH,
HWAS::DECONFIG,
HWAS::DELAYED_DECONFIG,
HWAS::GARD_NULL );
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/usr/isteps/istep16/call_host_activate_slave_cores.C
Expand Up @@ -293,7 +293,7 @@ void* call_host_activate_slave_cores (void *io_pArgs)
// Callout and gard core that failed to wake up.
l_errl->addHwCallout(*l_core,
HWAS::SRCI_PRIORITY_HIGH,
HWAS::DECONFIG,
HWAS::DELAYED_DECONFIG,
HWAS::GARD_Predictive);

// Could be an interrupt issue
Expand Down

0 comments on commit 75c0908

Please sign in to comment.