Remove clear(step 3) of reset vectors

Making the reset vector bits sticky to figure out hreset flow Clear the reset vectors on start cbs Change-Id: I78273cf14a3f623052e8c01618b2596323801207 Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57732 Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com> Tested-by: HWSV CI <hwsv-ci+hostboot@us.ibm.com> Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com> Reviewed-by: Sachin Gupta <sgupta2m@in.ibm.com> Reviewed-by: RAJA DAS <rajadas2@in.ibm.com> Reviewed-by: SRINIVAS V. POLISETTY <srinivan@in.ibm.com> Reviewed-by: Jennifer A. Stofer <stofer@us.ibm.com> Reviewed-on: http://ralgit01.raleigh.ibm.com/gerrit1/57738 Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com> Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com> Reviewed-by: Daniel M. Crowell <dcrowell@us.ibm.com>
open-power · May 18, 2018 · 764053f · 764053f
1 parent 775a763
commit 764053f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_sbe_hreset.C b/src/import/chips/p9/procedures/hwp/perv/p9_sbe_hreset.C
@@ -170,10 +170,6 @@ fapi2::ReturnCode p9_sbe_hreset(
         FAPI_TRY(l_data64.setBit(l_startVectorBit));
         FAPI_TRY(fapi2::putScom(i_target, PERV_SB_CS_SCOM, l_data64),
                  "Error from putScom to PERV_SB_CS_SCOM (2)");
-
-        FAPI_TRY(l_data64.clearBit(l_startVectorBit));
-        FAPI_TRY(fapi2::putScom(i_target, PERV_SB_CS_SCOM, l_data64),
-                 "Error from putScom to PERV_SB_CS_SCOM (3)");
     }
 
 #ifndef __HOSTBOOT_RUNTIME
@@ -203,9 +199,6 @@ fapi2::ReturnCode p9_sbe_hreset(
         FAPI_TRY(fapi2::putCfamRegister(i_target, PERV_SB_CS_FSI, l_data32),
                  "Error from putCfamRegister to PERV_SB_CS_FSI (2)");
 
-        FAPI_TRY(l_data32.clearBit(l_startVectorBit));
-        FAPI_TRY(fapi2::putCfamRegister(i_target, PERV_SB_CS_FSI, l_data32),
-                 "Error from putCfamRegister to PERV_SB_CS_FSI (3)");
     }
 
 #endif

diff --git a/src/import/chips/p9/procedures/hwp/perv/p9_start_cbs.C b/src/import/chips/p9/procedures/hwp/perv/p9_start_cbs.C
@@ -5,7 +5,7 @@
 /*                                                                        */
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
-/* Contributors Listed Below - COPYRIGHT 2015,2017                        */
+/* Contributors Listed Below - COPYRIGHT 2015,2018                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -95,6 +95,7 @@ fapi2::ReturnCode p9_start_cbs(const fapi2::Target<fapi2::TARGET_TYPE_PROC_CHIP>
     FAPI_DBG("Setting up hreset to 0");
     FAPI_TRY(fapi2::getCfamRegister(i_target_chip, PERV_SB_CS_FSI, l_data32));
     l_data32.clearBit<PERV_SB_CS_START_RESTART_VECTOR0>();
+    l_data32.clearBit<PERV_SB_CS_START_RESTART_VECTOR1>();
     FAPI_TRY(fapi2::putCfamRegister(i_target_chip, PERV_SB_CS_FSI, l_data32));
 
     FAPI_DBG("check for VDN_PGOOD");