Skip to content

Commit

Permalink
MPIPL: Copy all SBE data to hypervisor memory
Browse files Browse the repository at this point in the history
This patch fixes couple of regressions introduced by commit d99b1ed.
 - Setting wrong offset size. As per HDAT spec internal data structure
   array size should be 0x10.
 - Remove double increment of procNum

Fixes: d99b1ed (Add SBE Arch dump area for both OPAL & PHYP)
Change-Id: I8a3737c1375b74fb488136a3aefa3a4420cf1b6c
CC: Dean Sanner <dsanner@us.ibm.com>
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/91580
Reviewed-by: MURULIDHAR NATARAJU <murulidhar@in.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP Build CI <op-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins OP HW <op-hw-jenkins+hostboot@us.ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
Vasant Hegde authored and dcrowell77 committed Feb 17, 2020
1 parent 4617493 commit 76571f3
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/usr/dump/dumpCollect.C
Expand Up @@ -421,7 +421,6 @@ errlHndl_t copyArchitectedRegs(void)
uint64_t procSrcAddr = (reinterpret_cast<uint64_t>(vMapSrcAddrBase)+
procNum * VMM_ARCH_REG_DATA_PER_PROC_SIZE);
TRACDCOMP(g_trac_dump, "SBE Proc[%d] [%p]", procNum, procSrcAddr);
procNum++;

sbeArchRegDumpProcHdr_t *sbeProcHdr =
reinterpret_cast<sbeArchRegDumpProcHdr_t *>(procSrcAddr);
Expand Down Expand Up @@ -503,7 +502,7 @@ errlHndl_t copyArchitectedRegs(void)
hostHdr->pir = sbeTdHdr->pir;
hostHdr->coreState = sbeTdHdr->coreState;
hostHdr->iv_regArrayHdr.hdatOffset =
sizeof(hostArchRegDataHdr);
sizeof(HDAT::hdatHDIFDataArray_t);
hostHdr->iv_regArrayHdr.hdatArrayCnt = regCount;
hostHdr->iv_regArrayHdr.hdatAllocSize =
sizeof(hostArchRegDataEntry);
Expand Down

0 comments on commit 76571f3

Please sign in to comment.