Skip to content

Commit

Permalink
Disables broadcast mode in memdiags::continue_cmd
Browse files Browse the repository at this point in the history
Broadcast mode at runtime can cause issues.
memdiags::continue_cmd is called at runtime,
so disabling the broadcast mode check will
fix an NVDIMM runtime bug.

Change-Id: Ib13ad0bf46c44aa26a6df39ffabc507348a1a14e
CQ:SW480744
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86898
Reviewed-by: Mark Pizzutillo <mark.pizzutillo@ibm.com>
Tested-by: FSP CI Jenkins <fsp-CI-jenkins+hostboot@us.ibm.com>
Tested-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Tested-by: Hostboot CI <hostboot-ci+hostboot@us.ibm.com>
Reviewed-by: Louis Stermole <stermole@us.ibm.com>
Reviewed-by: Zane C Shelley <zshelle@us.ibm.com>
Reviewed-by: Caleb N Palmer <cnpalmer@us.ibm.com>
Reviewed-by: Jennifer A Stofer <stofer@us.ibm.com>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/86912
Reviewed-by: Jenkins Server <pfd-jenkins+hostboot@us.ibm.com>
Reviewed-by: Daniel M Crowell <dcrowell@us.ibm.com>
Tested-by: Daniel M Crowell <dcrowell@us.ibm.com>
  • Loading branch information
sglancy6 authored and dcrowell77 committed Nov 14, 2019
1 parent 06b4ead commit 78426dd
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/import/generic/memory/lib/utils/mcbist/gen_mss_memdiags.H
Expand Up @@ -1103,8 +1103,12 @@ fapi2::ReturnCode continue_cmd( const fapi2::Target<T>& i_target,
// Read-modify-write the fields in the program.
FAPI_TRY( mss::getScom(i_target, TT::MCBAGRAQ_REG, l_program.iv_addr_gen) );

// Configure broadcast mode if needed
FAPI_TRY(mss::mcbist::configure_broadcast_mode(i_target, l_program));
// Note: we are specifically not configuring broadcast mode here
// The continue command is called by PRD exclusively at mainline
// If we're at mainline, we can't run in broadcast mode
// If we ever need to call continue elsewhere, we'll need to do the following
// 1) add the function to configure broadcast mode
// 2) add in a switch to disable broadcast mode if we're at runtime

l_program.change_end_boundary(i_end);

Expand Down

0 comments on commit 78426dd

Please sign in to comment.